Skip to content

AUTH-482: set required-scc for openshift workloads #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

ShazaAldawamneh
Copy link
Contributor

This PR sets the required SCC explicitly on each workload in openshift-* namespaces. The SCC chosen is the one that the pods are getting admitted with, so no change expected there. This is to protect the pods from getting admitted with a different custom SCC than the one intended.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 14, 2024

@ShazaAldawamneh: This pull request references AUTH-482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.16" instead.

In response to this:

This PR sets the required SCC explicitly on each workload in openshift-* namespaces. The SCC chosen is the one that the pods are getting admitted with, so no change expected there. This is to protect the pods from getting admitted with a different custom SCC than the one intended.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 14, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@JoelSpeed
Copy link
Contributor

@ShazaAldawamneh Why is this WIP? What are we waiting on?

@ShazaAldawamneh ShazaAldawamneh changed the title [WIP]: AUTH-482: set required-scc for openshift workloads AUTH-482: set required-scc for openshift workloads Nov 21, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@ShazaAldawamneh
Copy link
Contributor Author

/retest-required

@JoelSpeed
Copy link
Contributor

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor

/retest

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@ShazaAldawamneh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi 460f490 link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-dualstack 460f490 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia 460f490 link false /test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

Our CI seems to be down at the moment, and it's affecting multiple tests which is concerning, need to look into this before we can proceed

@ShazaAldawamneh
Copy link
Contributor Author

thanks @JoelSpeed do you think this would be because of my code or because of something else ?

@JoelSpeed
Copy link
Contributor

I think it's something else, I'm investigating and trying to get this unblocked

@JoelSpeed
Copy link
Contributor

/retest-required

@JoelSpeed
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 317232b into openshift:master Dec 6, 2024
24 of 27 checks passed
@ShazaAldawamneh
Copy link
Contributor Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@ShazaAldawamneh: new pull request created: #1311

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.19.0-202412061937.p0.g317232b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants