Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-2051: implement e2e tests for vSphere multi network #1347

Merged
merged 2 commits into from
Apr 7, 2025
Merged

SPLAT-2051: implement e2e tests for vSphere multi network #1347

merged 2 commits into from
Apr 7, 2025

Conversation

rvanderp3
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2025 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-2051 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and nrb March 14, 2025 20:32
@rvanderp3
Copy link
Contributor Author

/uncc @JoelSpeed @nrb

@openshift-ci openshift-ci bot removed request for nrb and JoelSpeed March 14, 2025 20:32
@rvanderp3 rvanderp3 marked this pull request as draft March 14, 2025 20:33
@rvanderp3 rvanderp3 marked this pull request as ready for review April 3, 2025 20:35
@openshift-ci openshift-ci bot requested review from elmiko and JoelSpeed April 3, 2025 20:36
@vr4manta
Copy link
Contributor

vr4manta commented Apr 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@rvanderp3 rvanderp3 changed the title WIP: SPLAT-2051: implement e2e tests for vSphere multi network SPLAT-2051: implement e2e tests for vSphere multi network Apr 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2025
@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@rvanderp3
Copy link
Contributor Author

/assign @JoelSpeed

@jcpowermac
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-2051 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

nrb
nrb reviewed Apr 7, 2025
View reviewed changes
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
@vr4manta
Copy link
Contributor

vr4manta commented Apr 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
@rvanderp3
Copy link
Contributor Author

/assign @nrb

@nrb
Copy link
Contributor

nrb commented Apr 7, 2025

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 904c536 into openshift:main Apr 7, 2025
20 of 31 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upgrade f874bfc link false /test e2e-vsphere-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn f874bfc link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.20.0-202504080239.p0.g904c536.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrb nrb nrb left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@nrb nrb

@jcpowermac jcpowermac

@JoelSpeed JoelSpeed

@vr4manta vr4manta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rvanderp3 @openshift-ci-robot @vr4manta @jcpowermac @nrb @openshift-bot @JoelSpeed