OCPBUGS-45621: Fix `dynamic-system-reserved-calc.sh` when only `true` parameter is used #4733

oarribas · 2024-12-05T10:37:34Z

When using the dynamic-system-reserved-calc.sh command with only true parameter, the call to function dynamic_node_sizing only has 1 parameter, and then the call to function dynamic_cpu_sizing $2 has no parameter and fail.

Fixes: OCPBUGS-45621

- What I did

Changed the order of the parameters passed to function dynamic_node_sizing, as $4 is optional

- How to verify it

Run the command this way (to not override the default env file) and check the output file:

# NODE_SIZES_ENV=/tmp/node-sizing.txt /usr/local/sbin/dynamic-system-reserved-calc.sh true
# cat /tmp/node-sizing.txt

- Description for the changelog

Fix the dynamic-system-reserved-calc.sh script when only true parameter is used.

When using the command with only `true` parameter, the call to function `dynamic_node_sizing` only has 1 parameter, and `dynamic_cpu_sizing $2` has no parameter.

openshift-ci-robot · 2024-12-05T10:37:40Z

@oarribas: This pull request references Jira Issue OCPBUGS-45621, which is invalid:

expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When using the dynamic-system-reserved-calc.sh command with only true parameter, the call to function dynamic_node_sizing only has 1 parameter, and then the call to function dynamic_cpu_sizing $2 has no parameter and fail.

Fixes: OCPBUGS-45621

- What I did

Changed the order of the parameters passed to function dynamic_node_sizing, as $4 is optional

- How to verify it

Run the command this way (to not override the default env file) and check the output file:
# NODE_SIZES_ENV=/tmp/node-sizing.txt /usr/local/sbin/dynamic-system-reserved-calc.sh true
# cat /tmp/node-sizing.txt
- Description for the changelog

Fix the dynamic-system-reserved-calc.sh script when only true parameter is used.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

oarribas · 2024-12-05T10:41:38Z

/jira refresh

openshift-ci-robot · 2024-12-05T10:41:45Z

@oarribas: This pull request references Jira Issue OCPBUGS-45621, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @cpmeadors

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

oarribas · 2024-12-06T08:29:12Z

/retest

sairameshv

Thanks for the change @oarribas
/lgtm

oarribas · 2024-12-06T17:20:31Z

/retest

oarribas · 2025-03-07T07:55:51Z

/retest

oarribas · 2025-03-07T17:20:03Z

/retest-required

oarribas · 2025-03-18T13:34:56Z

/retest

oarribas · 2025-03-21T11:21:42Z

/retest-required

oarribas · 2025-03-21T14:25:26Z

/retest

openshift-ci · 2025-03-21T18:43:53Z

@oarribas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`4c5222c`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-azure-ovn-upgrade-out-of-change	`4c5222c`	link	false	`/test e2e-azure-ovn-upgrade-out-of-change`
ci/prow/e2e-vsphere-ovn-zones	`4c5222c`	link	false	`/test e2e-vsphere-ovn-zones`
ci/prow/4.12-upgrade-from-stable-4.11-images	`4c5222c`	link	true	`/test 4.12-upgrade-from-stable-4.11-images`
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade	`4c5222c`	link	false	`/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade`
ci/prow/cluster-bootimages	`4c5222c`	link	true	`/test cluster-bootimages`
ci/prow/e2e-aws-ovn-workers-rhel8	`4c5222c`	link	false	`/test e2e-aws-ovn-workers-rhel8`
ci/prow/okd-e2e-aws	`4c5222c`	link	false	`/test okd-e2e-aws`
ci/prow/e2e-ovirt-upgrade	`4c5222c`	link	false	`/test e2e-ovirt-upgrade`
ci/prow/e2e-aws-workers-rhel8	`4c5222c`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/okd-e2e-upgrade	`4c5222c`	link	false	`/test okd-e2e-upgrade`
ci/prow/e2e-azure	`4c5222c`	link	false	`/test e2e-azure`
ci/prow/e2e-gcp-op-ocl	`4c5222c`	link	false	`/test e2e-gcp-op-ocl`
ci/prow/okd-images	`4c5222c`	link	false	`/test okd-images`
ci/prow/e2e-azure-ovn-upgrade	`4c5222c`	link	false	`/test e2e-azure-ovn-upgrade`
ci/prow/e2e-ovirt	`4c5222c`	link	false	`/test e2e-ovirt`
ci/prow/e2e-aws-disruptive	`4c5222c`	link	false	`/test e2e-aws-disruptive`
ci/prow/okd-e2e-gcp-op	`4c5222c`	link	false	`/test okd-e2e-gcp-op`
ci/prow/okd-e2e-vsphere	`4c5222c`	link	false	`/test okd-e2e-vsphere`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

oarribas · 2025-03-31T11:10:11Z

/retest-required

sairameshv · 2025-05-21T14:19:59Z

Hello @djoshy ,

This change looks good from the node team side. Could you approve it?

cc: @harche

oarribas · 2025-05-27T17:07:39Z

Hi @djoshy, can this PR be approved as per above comment?

djoshy · 2025-05-27T17:13:26Z

Will defer to node teams approval, as I'm not a kubelet parameter expert.

/lgtm

openshift-ci · 2025-05-27T17:14:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, oarribas, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-05-27T21:51:18Z

@oarribas: An error was encountered updating to the MODIFIED state for bug OCPBUGS-45621 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


No response returned: Post "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-45621/transitions": POST https://issues.redhat.com/rest/api/2/issue/OCPBUGS-45621/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

When using the dynamic-system-reserved-calc.sh command with only true parameter, the call to function dynamic_node_sizing only has 1 parameter, and then the call to function dynamic_cpu_sizing $2 has no parameter and fail.

Fixes: OCPBUGS-45621

- What I did

Changed the order of the parameters passed to function dynamic_node_sizing, as $4 is optional

- How to verify it

Run the command this way (to not override the default env file) and check the output file:
# NODE_SIZES_ENV=/tmp/node-sizing.txt /usr/local/sbin/dynamic-system-reserved-calc.sh true
# cat /tmp/node-sizing.txt
- Description for the changelog

Fix the dynamic-system-reserved-calc.sh script when only true parameter is used.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-05-28T00:46:34Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202505280012.p0.gc8f545b.assembly.stream.el9.
All builds following this will include this PR.

oarribas · 2025-05-28T08:14:17Z

/jira refresh

openshift-ci-robot · 2025-05-28T08:14:20Z

@oarribas: An error was encountered updating to the MODIFIED state for bug OCPBUGS-45621 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


No response returned: Post "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-45621/transitions": POST https://issues.redhat.com/rest/api/2/issue/OCPBUGS-45621/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sairameshv · 2025-05-28T09:46:11Z

/jira refresh

openshift-ci-robot · 2025-05-28T09:46:16Z

@sairameshv: Jira Issue OCPBUGS-45621: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#4733

Jira Issue OCPBUGS-45621 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

BhargaviGudi · 2025-05-30T11:00:35Z

/cherry-pick release-4.19

openshift-cherrypick-robot · 2025-05-30T11:01:15Z

@BhargaviGudi: new pull request created: #5094

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

BhargaviGudi · 2025-05-30T11:01:32Z

/cherry-pick release-4.18

BhargaviGudi · 2025-05-30T11:01:37Z

/cherry-pick release-4.17

openshift-cherrypick-robot · 2025-05-30T11:02:12Z

@BhargaviGudi: new pull request created: #5095

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-05-30T11:02:19Z

@BhargaviGudi: new pull request created: #5096

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Fix dynamic_node_sizing when only true parameter is used

4c5222c

When using the command with only `true` parameter, the call to function `dynamic_node_sizing` only has 1 parameter, and `dynamic_cpu_sizing $2` has no parameter.

openshift-ci bot requested review from djoshy and umohnani8 December 5, 2024 10:38

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 5, 2024

openshift-ci bot requested a review from cpmeadors December 5, 2024 10:41

sairameshv reviewed Dec 6, 2024

View reviewed changes

openshift-ci bot assigned sairameshv Dec 6, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024

oarribas mentioned this pull request May 21, 2025

OCPBUGS-7747: Do not set cpu system reserve below the default value #5046

Open

openshift-ci bot assigned djoshy May 27, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025

openshift-merge-bot bot merged commit c8f545b into openshift:main May 27, 2025
40 of 53 checks passed

openshift-cherrypick-robot mentioned this pull request May 30, 2025

[release-4.19] OCPBUGS-56899: Fix dynamic-system-reserved-calc.sh when only true parameter is used #5094

Merged

openshift-cherrypick-robot mentioned this pull request May 30, 2025

[release-4.18] OCPBUGS-56900: Fix dynamic-system-reserved-calc.sh when only true parameter is used #5095

Merged

openshift-cherrypick-robot mentioned this pull request May 30, 2025

[release-4.17] OCPBUGS-56901: Fix dynamic-system-reserved-calc.sh when only true parameter is used #5096

Open

OCPBUGS-45621: Fix dynamic-system-reserved-calc.sh when only true parameter is used #4733

OCPBUGS-45621: Fix dynamic-system-reserved-calc.sh when only true parameter is used #4733

Uh oh!

Conversation

oarribas commented Dec 5, 2024

Uh oh!

openshift-ci-robot commented Dec 5, 2024

Uh oh!

oarribas commented Dec 5, 2024

Uh oh!

openshift-ci-robot commented Dec 5, 2024

Uh oh!

oarribas commented Dec 6, 2024

Uh oh!

sairameshv left a comment

Choose a reason for hiding this comment

Uh oh!

oarribas commented Dec 6, 2024

Uh oh!

oarribas commented Mar 7, 2025

Uh oh!

oarribas commented Mar 7, 2025

Uh oh!

oarribas commented Mar 18, 2025

Uh oh!

oarribas commented Mar 21, 2025

Uh oh!

oarribas commented Mar 21, 2025

Uh oh!

openshift-ci bot commented Mar 21, 2025

Uh oh!

oarribas commented Mar 31, 2025

Uh oh!

sairameshv commented May 21, 2025

Uh oh!

oarribas commented May 27, 2025

Uh oh!

djoshy commented May 27, 2025

Uh oh!

openshift-ci bot commented May 27, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented May 27, 2025

Uh oh!

openshift-bot commented May 28, 2025

Uh oh!

oarribas commented May 28, 2025

Uh oh!

openshift-ci-robot commented May 28, 2025

Uh oh!

sairameshv commented May 28, 2025

Uh oh!

openshift-ci-robot commented May 28, 2025

Uh oh!

BhargaviGudi commented May 30, 2025

Uh oh!

openshift-cherrypick-robot commented May 30, 2025

Uh oh!

BhargaviGudi commented May 30, 2025

Uh oh!

BhargaviGudi commented May 30, 2025

Uh oh!

openshift-cherrypick-robot commented May 30, 2025

Uh oh!

openshift-cherrypick-robot commented May 30, 2025

Uh oh!

Uh oh!

OCPBUGS-45621: Fix `dynamic-system-reserved-calc.sh` when only `true` parameter is used #4733

OCPBUGS-45621: Fix `dynamic-system-reserved-calc.sh` when only `true` parameter is used #4733