Skip to content

[release-4.18] OCPBUGS-51015: Enforce VIPs to be collocated at the same host #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

[release-4.18] OCPBUGS-51015: Enforce VIPs to be collocated at the same host #4865

merged 1 commit into from
Feb 28, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4844

/assign MaysaMacedo

@MaysaMacedo
Enforce VIPs to be collocated at the same host
5ec802a 
When using dual-stack with OpenStack, both IPv4 and IPv6
share the same Neutron Port and this makes OVN thinks that
both addresses are associated to the same Node, but that might
not always be true as keepalived can put them in separate Nodes.
To change that, let's make sure the API VIPs stays together through
state changes, the same goes for Ingress VIPs.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 18, 2025
Merged
@openshift-ci openshift-ci bot requested review from mdbooth and rvanderp3 February 18, 2025 21:36
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-50599 has been cloned as Jira Issue OCPBUGS-51015. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-51015: Enforce VIPs to be collocated at the same host

In response to this:

This is an automated cherry-pick of #4844

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-50599: Enforce VIPs to be collocated at the same host [release-4.18] OCPBUGS-51015: Enforce VIPs to be collocated at the same host Feb 18, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 18, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-51015, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-50599 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-50599 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #4844

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor

/test e2e-openstack-dualstack e2e-metal-ipi-ovn-dualstack

@MaysaMacedo
Copy link
Contributor

/cc @mkowalski

@openshift-ci openshift-ci bot requested a review from mkowalski February 19, 2025 01:30
@mkowalski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@mkowalski
Copy link
Contributor

/test e2e-metal-ipi-ovn-dualstack

@MaysaMacedo
Copy link
Contributor

/assign @djoshy

@MaysaMacedo
Copy link
Contributor

FYI, the same bug on 4.19 was already verified by QE
cc @imatza-rh @rlobillo

@djoshy
Copy link
Contributor

djoshy commented Feb 20, 2025

/label backport-risk-assessed
/approve

clean backport

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, mkowalski, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@rlobillo
Copy link

/label cherry-pick-approved

@ptalgulk01
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 27, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d3aff45 and 2 for PR HEAD 5ec802a in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d3aff45 and 2 for PR HEAD 5ec802a in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 27, 2025 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 5ec802a link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-techpreview 5ec802a link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-upi-zones 5ec802a link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-zones 5ec802a link false /test e2e-vsphere-ovn-zones
ci/prow/okd-scos-e2e-aws-ovn 5ec802a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d3aff45 and 2 for PR HEAD 5ec802a in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d3aff45 and 2 for PR HEAD 5ec802a in total

@openshift-merge-bot openshift-merge-bot bot merged commit 7f706b7 into openshift:release-4.18 Feb 28, 2025
17 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-51015: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-51015 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #4844

/assign MaysaMacedo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Author

@MaysaMacedo: new pull request created: #4884

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.18.0-202502280203.p0.g7f706b7.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth Awaiting requested review from mdbooth

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@mkowalski mkowalski Awaiting requested review from mkowalski

Assignees

@rbbratta rbbratta

@mkowalski mkowalski

@eurijon eurijon

@djoshy djoshy

@MaysaMacedo MaysaMacedo

@anuragthehatter anuragthehatter

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.