Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(not ready for review) OCPBUGS-38869: Update desired config in MCN on OCL update #4906

Conversation

isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Mar 7, 2025

Closes: OCPBUGS-38869

- What I did
This adds an MCN spec update during the OCL update flow to ensure the desired config version is properly set when OCL is enabled.

- How to verify it

  1. Create a cluster and enable OCL.
  2. Apply an MC targeting the MCP with OCL enabled.
  3. Watch the MCN objects during the MC application.
    • The DESIREDCONFIG column in the oc get machineconfignode output should update properly.
    • The spec.configVersion.desired value in the oc describe machineconfignode/<node-name> output should update properly.

- Description for the changelog
OCPBUGS-38869: Update desired config in MCN on OCL update

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-38869, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen changed the title OCPBUGS-38869: Update desired config in MCN on OCL update (no ready for review) OCPBUGS-38869: Update desired config in MCN on OCL update Mar 7, 2025
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@isabella-janssen isabella-janssen changed the title (no ready for review) OCPBUGS-38869: Update desired config in MCN on OCL update (not ready for review) OCPBUGS-38869: Update desired config in MCN on OCL update Mar 7, 2025
@isabella-janssen
Copy link
Member Author

/hold

This PR should be reviewed and tested after #4876 is merged in as this bug builds on changes made for MCO-1501.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2025
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-38869, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes: OCPBUGS-38869

- What I did
This adds an MCN spec update during the OCL update flow to ensure the desired config version is properly set when OCL is enabled.

- How to verify it

  1. Create a cluster and enable OCL.
  2. Apply an MC targeting the MCP with OCL enabled.
  3. Watch the MCN objects during the MC application.
  • The DESIREDCONFIG column in the oc get machineconfignode output should update properly.
  • The spec.configVersion.desired value in the oc describe machineconfignode/<node-name> output should update properly.

- Description for the changelog
OCPBUGS-38869: Update desired config in MCN on OCL update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen marked this pull request as ready for review March 18, 2025 12:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@isabella-janssen isabella-janssen force-pushed the ocpbugs-38869-mcnDesiredConfig branch from a8aeeb0 to 527a32a Compare March 18, 2025 12:46
@isabella-janssen isabella-janssen force-pushed the ocpbugs-38869-mcnDesiredConfig branch from 527a32a to b9f6f8d Compare March 18, 2025 12:47
@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: This pull request references Jira Issue OCPBUGS-38869. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Closes: OCPBUGS-38869

- What I did
This adds an MCN spec update during the OCL update flow to ensure the desired config version is properly set when OCL is enabled.

- How to verify it

  1. Create a cluster and enable OCL.
  2. Apply an MC targeting the MCP with OCL enabled.
  3. Watch the MCN objects during the MC application.
  • The DESIREDCONFIG column in the oc get machineconfignode output should update properly.
  • The spec.configVersion.desired value in the oc describe machineconfignode/<node-name> output should update properly.

- Description for the changelog
OCPBUGS-38869: Update desired config in MCN on OCL update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change b9f6f8d link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-upgrade-out-of-change b9f6f8d link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-techpreview b9f6f8d link false /test e2e-gcp-op-techpreview
ci/prow/e2e-gcp-op-ocl b9f6f8d link false /test e2e-gcp-op-ocl
ci/prow/okd-scos-e2e-aws-ovn b9f6f8d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants