NO-ISSUE: ensure that test output is being captured

[cheesesashimi]

- What I did

I removed the calls to ./hack/test-with-junit.sh within our e2e test suites. This scripts' purpose is to capture the go test output, write it to a file, and run go-junit on it to produce a junit.xml file that Prow can ingest. Unfortunately, it appears that the script is eating output from go test and not even writing it to the workspace upon failure. This means that we can't figure out the cause of the test failure. So while we'll lose our junit reporting, that is less important right now.

- How to verify it

Run the e2e test jobs. The output should be visible, regardless of the test outcome. However, note that we will no longer receive junit reporting in Prow from it.

- Description for the changelog
Remove junit processing for e2e tests

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RishabhSaini]

What about something like. Tested this locally:

diff --git a/hack/test-with-junit.sh b/hack/test-with-junit.sh
index 978b86792..759c671c1 100755
--- a/hack/test-with-junit.sh
+++ b/hack/test-with-junit.sh
@@ -27,7 +27,7 @@ function generate_junit_report() {
   if [ -n "$ARTIFACT_DIR" ] && [ -d "$ARTIFACT_DIR" ]; then
     JUNIT_LOCATION="$ARTIFACT_DIR/junit-$MAKEFILE_TARGET.xml"
     echo "junit report location: $JUNIT_LOCATION"
-    cat | tee >(go-junit-report > "$JUNIT_LOCATION")
+    go-junit-report | tee "$JUNIT_LOCATION"
   else
     echo "\$ARTIFACT_DIR not set or does not exists, no junit will be published"
     cat

[cheesesashimi]

What I was trying to do was allow the usual go test output to be printed to stdout as well as redirected to go-junit-report, which itself is redirected to a file. My reasoning is that some of our tests generate useful output that belongs in the test logs and we shouldn't lose that. Maybe we do something like this instead:

tee "$test_output";
cat "$test_output" | go-junit-report > "$JUNIT_LOCATION";

In the future, we may want to adopt something like gotestsum which can do a lot of this for us.

[openshift-ci]

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift	079ff72	link	true	/test e2e-hypershift
ci/prow/e2e-gcp-op-single-node	079ff72	link	true	/test e2e-gcp-op-single-node
ci/prow/e2e-gcp-op-techpreview	079ff72	link	false	/test e2e-gcp-op-techpreview
ci/prow/okd-scos-e2e-aws-ovn	079ff72	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-ocl	079ff72	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-azure-ovn-upgrade-out-of-change	079ff72	link	false	/test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.