-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(not ready for review) OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired
update in MCN
#4909
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@isabella-janssen: This pull request references Jira Issue OCPBUGS-52302, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closes: OCPBUGS-52302
- What I did
This moves the MCN spec update earlier in the update flow (before the compatibility check is started) to align with the intended functionality as highlighted in the enhancement & API discussions on the intent of the field.
- How to verify it
Spec.ConfigVersion.Desired
value should update beforeStatus.ConfigVersion.Desired
.To see the full MCN object
**The
DESIREDCONFIG
column in the following command is populated usingSpec.ConfigVersion.Desired
and should flip before theUPDATEPREPARED
column flips toTrue
.- Description for the changelog
OCPBUGS-52302: Fix timing of Spec.ConfigVersion.Desired update in MCN