[MCO-1591] Ignition recursive converter #4913
Conversation
This commit bumps ignition to v2.20.0 to further bump the MCO to use ignition 3.5 by default. The ignition converter is bumped too.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pablintino
force-pushed
the
ignition-recursive-converter
branch
2 times, most recently
from
70c5bbf to
cade8da
Compare
Maintaining Ignition conversions is starting to be more and more complicated since each new version requires not only to code the conversion logic (by calling the underlaying Ignition converter) but adding the version to the MCS logic, update each comment that points to the old version or the supported version list, etc. This change aims to simplify the new Ignition bumps by providing a recursive converter that handles conversion between known versions transparently and exposes methods to retrieve the supported versions and to perform a coversion between known source and target versions. With this change, the dev in future Ignition bumps, will only need to bump the Ignition dependency and add two tiny functions that converts to and from the previous ignition version.
pablintino
force-pushed
the
ignition-recursive-converter
branch
from
cade8da to
37f7967
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
- What I did
TBD
- How to verify it
TBD
- Description for the changelog
TBD