Skip to content

OCPBUGS-52827: Fixing typos for MachineConfigNode #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

NoahArrowood
Copy link

Closes : OCPBUGS-52827

- What I did
Fixed typos for MachineConfigNode.

- How to verify it
N/A

- Description for the changelog
OCPBUGS-52827: Fixes typos for MachienConfigNode

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2025
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

Hi @NoahArrowood. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member

/label ok-to-test

Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@isabella-janssen: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2025
@isabella-janssen
Copy link
Member

/retest-required

@isabella-janssen
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@isabella-janssen: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@NoahArrowood NoahArrowood changed the title OCPBUGS-52827 : Fixing typos for MachineConfigNode OCPBUGS-52827: Fixing typos for MachineConfigNode Mar 17, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 17, 2025
@openshift-ci-robot
Copy link
Contributor

@NoahArrowood: This pull request references Jira Issue OCPBUGS-52827, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Closes : OCPBUGS-52827

- What I did
Fixed typos for MachineConfigNode.

- How to verify it
N/A

- Description for the changelog
OCPBUGS-52827: Fixes typos for MachienConfigNode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr March 17, 2025 14:02
@ptalgulk01
Copy link

ptalgulk01 commented Mar 18, 2025

Pre-merge verified:
Using IPI based AWS cluster

Applied CRC config
cat update/containerRuntime_worker.yaml
apiVersion: machineconfiguration.openshift.io/v1
kind: ContainerRuntimeConfig
metadata:
 name: crt-worker
 labels:
   machineconfiguration.openshift.io/role: worker 
spec:
 machineConfigPoolSelector:
   matchLabels:
     pools.operator.machineconfiguration.openshift.io/worker: ''
 containerRuntimeConfig:
   pidsLimit: 2048
   logLevel: debug
   overlaySize: 8G
   logSizeMax: "-1"
- Check the edits in MCN
$ oc describe machineconfignode ip-10-0-14-62.us-east-2.compute.internal
   Last Transition Time:  2025-03-18T07:51:18Z
    Message:               Action during update to rendered-worker-21da712b4486addace6cf29db5f4e537: Upgrade required a reboot. Completed this as the post update action.
    Reason:                UpdatePostActionCompleteRebootedNode
    Status:                False
    Type:                  RebootedNode
    Last Transition Time:  2025-03-18T05:16:15Z

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 18, 2025
@openshift-ci-robot
Copy link
Contributor

@NoahArrowood: This pull request references Jira Issue OCPBUGS-52827, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

Closes : OCPBUGS-52827

- What I did
Fixed typos for MachineConfigNode.

- How to verify it
N/A

- Description for the changelog
OCPBUGS-52827: Fixes typos for MachienConfigNode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member

isabella-janssen commented Mar 18, 2025

/approved

@djoshy
Copy link
Contributor

djoshy commented Mar 18, 2025

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, NoahArrowood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@isabella-janssen
Copy link
Member

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@NoahArrowood: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl feb8d94 link false /test e2e-gcp-op-ocl
ci/prow/okd-scos-e2e-aws-ovn feb8d94 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change feb8d94 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d96d261 and 2 for PR HEAD feb8d94 in total

@openshift-merge-bot openshift-merge-bot bot merged commit fe8353e into openshift:main Mar 19, 2025
14 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@NoahArrowood: Jira Issue OCPBUGS-52827: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52827 has been moved to the MODIFIED state.

In response to this:

Closes : OCPBUGS-52827

- What I did
Fixed typos for MachineConfigNode.

- How to verify it
N/A

- Description for the changelog
OCPBUGS-52827: Fixes typos for MachienConfigNode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202503191139.p0.gfe8353e.assembly.stream.el9.
All builds following this will include this PR.

@isabella-janssen
Copy link
Member

/cherry-pick release-4.18 release-4.17 release-4.16

@openshift-cherrypick-robot

@isabella-janssen: new pull request created: #4927

In response to this:

/cherry-pick release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants