OCPBUGS-54175: Add /etc/docker/certs.d to template #4933
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@tmshort: This pull request references Jira Issue OCPBUGS-52282, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@tmshort: This pull request references Jira Issue OCPBUGS-52282, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rphillips, tmshort The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Still get https://issues.redhat.com/browse/OCPBUGS-48795, details: https://issues.redhat.com/browse/OCPBUGS-52282 |
openshift-ci
bot
added
the
do-not-merge/hold
This is expected due to the runlevel difference between OLM and MCO. |
|
/retest-required |
tmshort
changed the title
|
@tmshort: This pull request references Jira Issue OCPBUGS-54175, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tmshort: This pull request references Jira Issue OCPBUGS-54175, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This can't be tested as part of OCPBUGS-52282, when it is backported to 4.18, it can then be tested with that bug. |
|
Test pass, details: https://issues.redhat.com/browse/OCPBUGS-54175 |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config. Signed-off-by: Todd Short <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
@rphillips can I get another LGTM? I rebased. |
|
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
OLMv1 uses containers/images/v5 which looks in the /etc/docker/certs.d directory for certificates used in image fetching. It is necessary for local registries as well as additional CAs specified in images.config.
- What I did
Added /etc/docker/certs.d to template
- How to verify it
Ensure /etc/docker/certs.d exists after cluster startup
- Description for the changelog
Add /etc/docker/certs.d to template