MCO-1505: allows user-configurable resource requests and limits via MachineOSConfig annotations

[cheesesashimi]

- What I did

To allow resource requests and limits to be set for on-cluster layering (OCL), I added the capability of setting these values via an annotation on the MachineOSConfig object. Additionally, in the absence of these annotations being set, we now have a default resource request set that mirrors the resource requests of the rest of the MCO's components.

- How to verify it

1. Bring up an OCL-enabled cluster.
2. Set any of the following annotations on a MachineOSConfig:
   • machineconfiguration.openshift.io/cpu-request
   • machineconfiguration.openshift.io/cpu-limit
   • machineconfiguration.openshift.io/memory-request
   • machineconfiguration.openshift.io/memory-limit
   • machineconfiguration.openshift.io/storage-request
   • machineconfiguration.openshift.io/storage-limit
   • machineconfiguration.openshift.io/ephemeral-storage-request
   • machineconfiguration.openshift.io/ephemeral-storage-limit
3. Trigger a new build.
4. The containers on the pod where the new MachineOSBuild is running should have those resource requests / limits set.

In the absence of those values being set, CPU should be set to 20m and memory should be set to 50Mi. The default resource request values are the same as the ones applied to the various MCO components.

- Description for the changelog
Allows user-configurable resource requests and limits via MachineOSConfig annotations

[openshift-ci-robot]

@cheesesashimi: This pull request references MCO-1505 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

To allow resource requests and limits to be set for on-cluster layering (OCL), I added the capability of setting these values via an annotation on the MachineOSConfig object. Additionally, in the absence of these annotations being set, we now have a default resource request set that mirrors the resource requests of the rest of the MCO's components.

- How to verify it

1. Bring up an OCL-enabled cluster.
2. Set any of the following annotations on a MachineOSConfig:
   • machineconfiguration.openshift.io/cpu-request
   • machineconfiguration.openshift.io/cpu-limit
   • machineconfiguration.openshift.io/memory-request
   • machineconfiguration.openshift.io/memory-limit
   • machineconfiguration.openshift.io/storage-request
   • machineconfiguration.openshift.io/storage-limit
   • machineconfiguration.openshift.io/ephemeral-storage-request
   • machineconfiguration.openshift.io/ephemeral-storage-limit
3. Trigger a new build.
4. The containers on the pod where the new MachineOSBuild is running should have those resource requests / limits set.

In the absence of those values being set, CPU should be set to 20m and memory should be set to 50Mi.

- Description for the changelog
Allows user-configurable resource requests and limits via MachineOSConfig annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@cheesesashimi: This pull request references MCO-1505 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did

To allow resource requests and limits to be set for on-cluster layering (OCL), I added the capability of setting these values via an annotation on the MachineOSConfig object. Additionally, in the absence of these annotations being set, we now have a default resource request set that mirrors the resource requests of the rest of the MCO's components.

- How to verify it

1. Bring up an OCL-enabled cluster.
2. Set any of the following annotations on a MachineOSConfig:
   • machineconfiguration.openshift.io/cpu-request
   • machineconfiguration.openshift.io/cpu-limit
   • machineconfiguration.openshift.io/memory-request
   • machineconfiguration.openshift.io/memory-limit
   • machineconfiguration.openshift.io/storage-request
   • machineconfiguration.openshift.io/storage-limit
   • machineconfiguration.openshift.io/ephemeral-storage-request
   • machineconfiguration.openshift.io/ephemeral-storage-limit
3. Trigger a new build.
4. The containers on the pod where the new MachineOSBuild is running should have those resource requests / limits set.

In the absence of those values being set, CPU should be set to 20m and memory should be set to 50Mi. The default resource request values are the same as the ones applied to the various MCO components.

- Description for the changelog
Allows user-configurable resource requests and limits via MachineOSConfig annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op-ocl	bee5f07	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-aws-ovn-upgrade-out-of-change	bee5f07	link	false	/test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-azure-ovn-upgrade-out-of-change	bee5f07	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-upgrade	bee5f07	link	true	/test e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn	bee5f07	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn	bee5f07	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.