Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: change branch to main for openshift/api ref in Makefile #4951

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cheesesashimi
Copy link
Member

@cheesesashimi cheesesashimi commented Mar 25, 2025

- What I did

When openshift/release#62711 lands, we need to update our Makefile to reference main instead of master. With the path format referenced in our Makefile, GitHub will auto-redirect to main. However, we should still plan for it to be updated anyway.

NOTE: openshift/release#62711 must land first otherwise this change will not work.

- How to verify it

Run make bootstrap-e2e, which should pass. Alternatively, run the bootstrap-e2e CI job, which should also pass.

- Description for the changelog
Update API URL in Makefile for branch name change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2025
@cheesesashimi cheesesashimi changed the title change branch to main for openshift/api ref in Makefile NO-ISSUE: change branch to main for openshift/api ref in Makefile Mar 25, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2025
@openshift-ci-robot
Copy link
Contributor

@cheesesashimi: This pull request explicitly references no jira issue.

In response to this:

- What I did

When openshift/release#62711 lands, we need to update our Makefile to reference main instead of master. With the path format referenced in our Makefile, GitHub will auto-redirect to main. However, we should still plan for it to be updated anyway.

- How to verify it

Run make bootstrap-e2e, which should pass. Alternatively, run the bootstrap-e2e CI job, which should also pass.

- Description for the changelog
Update API URL in Makefile for branch name change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants