Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ART-11792] add missing vendors #4952

Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from
Open

[ART-11792] add missing vendors #4952

wants to merge 1 commit into from

Conversation

ashwindasr
Copy link

@ashwindasr ashwindasr commented Mar 25, 2025 •
edited
Loading

Image build for machine-config-operator on 4.16 was failing on Konflux due to missing go mod dependencies.

2025-03-25 20:54:57,063 ERROR vendor directory changed after vendoring:
M	vendor/github.com/openshift/api/operator/v1alpha1/zz_generated.crd-manifests/0000_10_etcd_01_etcdbackups-TechPreviewNoUpgrade.crd.yaml
M	vendor/k8s.io/code-generator/generate-groups.sh
M	vendor/k8s.io/code-generator/generate-internal-groups.sh

@jupierce jupierce added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Mar 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ashwindasr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jupierce jupierce added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 25, 2025
@ashwindasr
Copy link
Author

/retest

1 similar comment
@ashwindasr
Copy link
Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@rbbratta rbbratta

@eurijon eurijon

@zhaozhanqi zhaozhanqi

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@rlobillo rlobillo

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.