OKD-239: Consolidate OpenStack and PowerVS hostname handling into mco-hostname script

templates/common/_base/files/usr-local-bin-mco-hostname.yaml

@@ -3,6 +3,8 @@ path: "/usr/local/bin/mco-hostname"
 contents:
   inline: |
     #!/bin/bash
+    set -euo pipefail
+
     # First, we need to wait until DHCP finishes and the node has a non-`localhost`
     # hostname before `kubelet.service` starts.
     # That's the `--wait` argument as used by `node-valid-hostname.service`.
@@ -57,9 +59,27 @@ contents:
         exit 0
     }
 
+    set_openstack_hostname() {
+        # Read metadata written by afterburn service
+        . /run/metadata/afterburn
+
+        # node-valid-hostname sets persistent hostname from /proc/sys/kernel/hostname
+        echo "$AFTERBURN_OPENSTACK_HOSTNAME" > /proc/sys/kernel/hostname
+    }
+
+    set_powervs_hostname() {
+        # Read metadata written by afterburn service
+        . /run/metadata/afterburn
+
+        # node-valid-hostname sets persistent hostname from /proc/sys/kernel/hostname
+        echo "$AFTERBURN_POWERVS_LOCAL_HOSTNAME" > /proc/sys/kernel/hostname
+    }
+
     arg=${1}; shift;
     case "${arg}" in
         --wait) wait_localhost;;
         --gcp) set_gcp_hostname;;
+        --openstack) set_openstack_hostname;;
+        --powervs) set_powervs_hostname;;
         *) echo "Unhandled arg $arg"; exit 1
     esac

templates/common/openstack/units/afterburn-hostname.service.yaml → templates/common/openstack/units/openstack-hostname.service.yaml

@@ -1,4 +1,4 @@
-name: afterburn-hostname.service
+name: openstack-hostname.service
 enabled: true
 contents: |
   [Unit]
@@ -9,14 +9,17 @@ contents: |
   After=NetworkManager-wait-online.service
   # Run before hostname checks
   Before=node-valid-hostname.service
+  # We require afterburn to have run first
+  Requires=afterburn.service
+  After=afterburn.service
 
   [Service]
   # Would prefer to do Restart=on-failure instead of this bash retry loop, but
   # the version of systemd we have right now doesn't support it. It should be
   # available in systemd v244 and higher.
   ExecStart=/bin/bash -c " \
   until \
-  /usr/local/bin/openstack-afterburn-hostname; \
+  /usr/local/bin/mco-hostname --openstack; \
   do \
   sleep 10; \
   done"
@@ -26,4 +29,4 @@ contents: |
   RemainAfterExit=true
 
   [Install]
-  WantedBy=network-online.target
+  WantedBy=node-valid-hostname.service

templates/common/powervs/units/afterburn-hostname.service.yaml → templates/common/powervs/units/powervs-hostname.service.yaml

@@ -1,4 +1,4 @@
-name: afterburn-hostname.service
+name: powervs-hostname.service
 enabled: true
 contents: |
   [Unit]
@@ -9,10 +9,13 @@ contents: |
   After=NetworkManager-wait-online.service
   # Run before hostname checks
   Before=node-valid-hostname.service
+  # We require afterburn to have run first
+  Requires=afterburn.service
+  After=afterburn.service
 
   [Service]
-  ExecStart=/usr/bin/afterburn --provider powervs --hostname=/etc/hostname
   Type=oneshot
+  ExecStart=/usr/local/bin/mco-hostname --powervs
 
   [Install]
-  WantedBy=network-online.target
+  WantedBy=node-valid-hostname.service