MCO-1661: Feature Gate handling rework

[pablintino]

- What I did

This change reworks the way we interact with configv1.FeatureGate. Till this change we interacted with them using the featuregates.FeatureGateAccess interface directly, making us handle fetching errors each time we simply need to check for a FeatureGate.
This change still fetches FeatureGates through featuregates.FeatureGateAccess but it creates an easy to use wrapper around it that handles the only error that can happen (checking FeatureGates before the internal go routine finishes grabing them) in a common block that is now reused in each of our components.
Access to FeatureGates with the workflow the wrapper leaves is as simple as calling Enabled passing the FeatureGate as value and that's all.

- How to verify it

Deploy two OCP clusters, one with TechPreviewNoUpgrade enabled and other without it. Our features MachineConfigNodes and PinnedImages should be properly showing up and working.

- Description for the changelog

This change implements a wrapper around featuregates.FeatureGateAccess to centralize the way we handle FeatureGates checks. The handler exposes a few error-free methods to check if a FeatureGate is enabled or not or if it exist or not.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@pablintino: This pull request references MCO-1661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pablintino]

/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pablintino]

/test unit

[openshift-ci-robot]

@pablintino: This pull request references MCO-1661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did
This change reworks the way we interact with configv1.FeatureGate. Till this change we interacted with them using the featuregates.FeatureGateAccess interface directly, making us handle fetching errors each time we simply need to check for a FeatureGate.
This change still fetches FeatureGates through featuregates.FeatureGateAccess but it creates an easy to use wrapper around it that handles the only error that can happen (checking FeatureGates before the internal go routine finishes grabing them) in a common block that is now reused in each of our components.
Access to FeatureGates with the workflow the wrapper leaves is as simple as calling Enabled passing the FeatureGate as value and that's all.
- How to verify it
Deploy two OCP clusters, one with TechPreviewNoUpgrade enabled and other without it. Our features MachineConfigNodes and PinnedImages should be properly showing up and working.
- Description for the changelog
This change implements a wrapper around featuregates.FeatureGateAccess to centralize the way we handle FeatureGates checks. The handler exposes a few error-free methods to check if a FeatureGate is enabled or not or if it exist or not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@pablintino: This pull request references MCO-1661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

This change reworks the way we interact with configv1.FeatureGate. Till this change we interacted with them using the featuregates.FeatureGateAccess interface directly, making us handle fetching errors each time we simply need to check for a FeatureGate.
This change still fetches FeatureGates through featuregates.FeatureGateAccess but it creates an easy to use wrapper around it that handles the only error that can happen (checking FeatureGates before the internal go routine finishes grabing them) in a common block that is now reused in each of our components.
Access to FeatureGates with the workflow the wrapper leaves is as simple as calling Enabled passing the FeatureGate as value and that's all.

- How to verify it

Deploy two OCP clusters, one with TechPreviewNoUpgrade enabled and other without it. Our features MachineConfigNodes and PinnedImages should be properly showing up and working.

- Description for the changelog

This change implements a wrapper around featuregates.FeatureGateAccess to centralize the way we handle FeatureGates checks. The handler exposes a few error-free methods to check if a FeatureGate is enabled or not or if it exist or not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@pablintino: This pull request references MCO-1661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

- What I did

This change reworks the way we interact with configv1.FeatureGate. Till this change we interacted with them using the featuregates.FeatureGateAccess interface directly, making us handle fetching errors each time we simply need to check for a FeatureGate.
This change still fetches FeatureGates through featuregates.FeatureGateAccess but it creates an easy to use wrapper around it that handles the only error that can happen (checking FeatureGates before the internal go routine finishes grabing them) in a common block that is now reused in each of our components.
Access to FeatureGates with the workflow the wrapper leaves is as simple as calling Enabled passing the FeatureGate as value and that's all.

- How to verify it

Deploy two OCP clusters, one with TechPreviewNoUpgrade enabled and other without it. Our features MachineConfigNodes and PinnedImages should be properly showing up and working.

- Description for the changelog

This change implements a wrapper around featuregates.FeatureGateAccess to centralize the way we handle FeatureGates checks. The handler exposes a few error-free methods to check if a FeatureGate is enabled or not or if it exist or not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pablintino]

/test unit

[openshift-ci]

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	afd01b6	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/unit	afd01b6	link	true	/test unit
ci/prow/e2e-gcp-op-ocl	afd01b6	link	false	/test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.