OCPBUGS-55681: Give keepalived container chroot cap #5032
Conversation
When we switched our containers to use capabilities intead of giving them full admin access to everything, we missed that the keepalived container needs to be able to chroot for one of its health checks. Because this check is always failing now, we may place the VIP incorrectly and break access to ingress services on the cluster. This just adds the necessary capability to the container. There will be a followup change in the origin repo to add a test that would have caught this, since it's not a problem in a normal CI run.
openshift-ci-robot
added
jira/valid-reference
|
@cybertron: This pull request references Jira Issue OCPBUGS-55681, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@cybertron: This pull request references Jira Issue OCPBUGS-55681, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest-required This is not used in aws. |
|
/retest-required |
|
/lgtm |
|
/assign @cheesesashimi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, mkowalski, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 58508e1
into
openshift:main
|
@cybertron: Jira Issue OCPBUGS-55681: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55681 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.19,release-4.18,release-4.17 |
|
@cybertron: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #5072 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: new pull request created: #5073 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci-robot: new pull request created: #5074 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
When we switched our containers to use capabilities intead of giving them full admin access to everything, we missed that the keepalived container needs to be able to chroot for one of its health checks. Because this check is always failing now, we may place the VIP incorrectly and break access to ingress services on the cluster. This just adds the necessary capability to the container.
There will be a followup change in the origin repo to add a test that would have caught this, since it's not a problem in a normal CI run.
- What I did
- How to verify it
- Description for the changelog