OCPBUGS-51365: Move Multus manifests from RPM to embedded assets & run kustomizer standalone #4697
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@pmtk: This pull request references Jira Issue OCPBUGS-51365, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@pmtk: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
approved
|
/test e2e-aws-tests-bootc-arm e2e-aws-tests-bootc-periodic |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@pmtk: This pull request references Jira Issue OCPBUGS-51365, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
openshift-merge-robot
added
the
needs-rebase
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
a20517d to
ce18b70
Compare
openshift-merge-robot
removed
the
needs-rebase
pmtk
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
ce18b70 to
2b75ebf
Compare
|
/retest |
openshift-merge-robot
added
the
needs-rebase
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
2b75ebf to
5c70fc1
Compare
openshift-merge-robot
removed
the
needs-rebase
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
d8d3559 to
8924a9e
Compare
|
/retest |
1 similar comment
|
/retest |
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
8924a9e to
2ab473a
Compare
openshift-merge-robot
added
the
needs-rebase
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
2ab473a to
6b6e265
Compare
openshift-merge-robot
removed
the
needs-rebase
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
6b6e265 to
55b02e6
Compare
| @@ -521,6 +521,11 @@ network: | |||
| # assumes an empty string to mean the OVN-K should be deployed. | |||
| # Allowed values are: unset or one of ["", "ovnk", "none"] | |||
| cniPlugin: "" | |||
| multus: | |||
| # Status controls the deployment of the Multus CNI. | |||
| # Changing from "Enabled" to "Disabled" will not cause Multus CNI to be deleted. | |||
There was a problem hiding this comment.
Just as a note, we need to ensure this is highlighted in the docs, as its the first time that a configuration option is not reversible?
There was a problem hiding this comment.
I think storage (lvms) also follows that route.
ref:
Automated uninstallation is not supported as this can cause orphaning of the provisioned volumes. Without the LVMS CSI driver, the cluster does not have knowledge of the underlying storage interface and cannot perform provisioning and deprovisioning or mounting and unmounting operations
There was a problem hiding this comment.
Also, microshift-multus.rpm will continue existing, except it'll just contain the drop in, so from user's perspective it's the same (they could remove the rpm with the manifests, but the objects in api server would continue living).
openshift-merge-robot
added
the
needs-rebase
pmtk
force-pushed
the
kustomizer-bug/multus
branch
from
55b02e6 to
457a867
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacevedom, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@pmtk: Jira Issue OCPBUGS-51365: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-51365 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.