USHIFT-5461: Implement S3 caching for container images in layer1 #4718
Conversation
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test ? |
|
@ggiguash: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-tests-cache |
1 similar comment
|
/test e2e-aws-tests-cache |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-bootc |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-tests-bootc |
ggiguash
force-pushed
the
registry-cache-over-vpn
branch
from
a50ff29 to
27c8efe
Compare
|
/test e2e-aws-tests-bootc |
3 similar comments
|
/test e2e-aws-tests-bootc |
|
/test e2e-aws-tests-bootc |
|
/test e2e-aws-tests-bootc |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: This pull request references USHIFT-5461 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ggiguash
force-pushed
the
registry-cache-over-vpn
branch
from
eabc874 to
216c2c1
Compare
|
/test e2e-aws-tests-bootc |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test e2e-aws-tests-cache |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| location = "localhost" | ||
| [[registry.mirror]] | ||
| location = "${MIRROR_REGISTRY_URL}" | ||
| insecure = true |
There was a problem hiding this comment.
Does this mean that for localhost/IMAGE it will always attempt to first use mirror instead of local storage?
| # See https://docs.projectquay.io/deploy_quay.html#poc-configuring-database | ||
| if [ ! -d "${MIRROR_REGISTRY_DIR}/postgres" ] ; then | ||
| mkdir -p "${MIRROR_REGISTRY_DIR}/postgres" | ||
| setfacl -m u:26:-wx "${MIRROR_REGISTRY_DIR}/postgres" | ||
| # setfacl -m u:26:-wx "${MIRROR_REGISTRY_DIR}/postgres" |
There was a problem hiding this comment.
Should we remove it? It can be always pulled from the history if needed.
| setfacl -m u:1001:-wx "${MIRROR_REGISTRY_DIR}/storage" | ||
| if [ ! -d "${QUAY_STORAGE_DIR}" ] ; then | ||
| mkdir -p "${QUAY_STORAGE_DIR}" | ||
| setfacl -m u:1001:-wx "${QUAY_STORAGE_DIR}" |
There was a problem hiding this comment.
Can we run quay container as "$(id -u):$(id -g)"?
Attempt copying container images from the local mirror registry to container storage and skip the builds if the copy succeeds. The
--force-rebuildflag overrides this behavior by always rebuilding the images.The time saving seems to be around 5m for the image build step as that's the time it takes to build
layer1when ISO images are skipped.Notes:
infra-iso-buildtimes are presented