[oadp-1.4] OADP-4995: Add support for legacy aws plugin

[sseago]

Why the changes were made

Certain s3 providers don't support the AWS SDK v2 updates made in velero-plugin-for-aws v1.9+ (OADP 1.4+). This PR provides the ability to use the v1.8 plugin in a newer OADP environment.

How to test the changes made

In the DPA DefaultPlugins section, use legacy-aws instead of aws. S3 providers that work with the regular aws plugin should still work here. S3 providers that error out in various ways with the regular plugin should also work.

[sseago]

/override ci/prow/4.17-e2e-test-kubevirt-aws

[openshift-ci]

@sseago: Overrode contexts on behalf of sseago: ci/prow/4.17-e2e-test-kubevirt-aws

In response to this:

/override ci/prow/4.17-e2e-test-kubevirt-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@sseago: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.18-dev-preview-e2e-test-aws	9c4e9a9	link	false	/test 4.18-dev-preview-e2e-test-aws
ci/prow/4.17-e2e-test-kubevirt-aws	9c4e9a9	link	true	/test 4.17-e2e-test-kubevirt-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@sseago: This pull request references OADP-4995 which is a valid jira issue.

In response to this:

Why the changes were made

Certain s3 providers don't support the AWS SDK v2 updates made in velero-plugin-for-aws v1.9+ (OADP 1.4+). This PR provides the ability to use the v1.8 plugin in a newer OADP environment.

How to test the changes made

In the DPA DefaultPlugins section, use legacy-aws instead of aws. S3 providers that work with the regular aws plugin should still work here. S3 providers that error out in various ways with the regular plugin should also work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mateusoliveira43]

this change is right?

[sseago]

@mateusoliveira43 This file was created from make bundle -- I'm not sure why createdAt was removed. I just tried again in my checkout, removed the file and re-ran make bundle and it's the same.

@shubham-pampattiwar @kaovilai Any idea why this would happen?

[weshayutin]

whayutin@thinkdoe:/tmp$ oc get dpa dpa-sample -o yaml | grep aws
      provider: aws
      - aws
      provider: aws
whayutin@thinkdoe:/tmp$ oc get dpa dpa-sample -o yaml | grep aws
      provider: aws
      - legacy-aws
      provider: aws
whayutin@thinkdoe:/tmp$ oc get dpa dpa-sample -o yaml | grep -i recon
    message: Reconcile complete
    type: Reconciled

also ran a backup w/ legacy-aws

vol24-ttl-short   Completed   0        0          2024-10-24 13:59:10 +0000 UTC   55m       dpa-sample-1       <none>l

[weshayutin]

/LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment