OADP-5782: Add hypershift-oadp-plugin E2E tests #1684

jparrill · 2025-03-27T20:06:47Z

Why the changes were made

This PR add the E2E tests for hypershift-oadp-plugin. It includes also:

Some new functions in the original libraries
Changed a bit how the the scheme is imported into the E2E
Added a test suite only for HCP with many helper functions
Fixes: Add unsupportedOverrides unit test for hypershift. #1685

How to test the changes made

Execute the E2E with this command:

export HYPERSHIFT_PLUGIN_IMAGE=quay.io/hypershift/hypershift-oadp-plugin:latest
export OADP_CRED_FILE=<PATH_TO_CREDS>
export OADP_BUCKET=<BUCKET_NAME>
export CI_CRED_FILE=<PATH_TO_CREDS>
export VSL_REGION=<AWS_REGION>
export BSL_REGION=<AWS_REGION>
export OPENSHIFT_CI=false

TEST_HCP=true make test-e2e GINKGO_ARGS="--ginkgo.focus='HCP Backup and Restore tests'"

openshift-ci · 2025-03-27T20:07:05Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-03-27T20:07:17Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-27T20:07:37Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-27T20:09:22Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-27T20:10:51Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copilot

Pull Request Overview

This PR introduces end-to-end tests for the hypershift-oadp-plugin and extends functionality to support hypershift scenarios throughout the codebase. It also adds new functions, updates the CRDs, manifests, and configuration files to include hypershift plugin references.

Added YAML sample manifests for hypershift
Introduced hypershift support in the scheme, backup, credentials, and controller tests
Updated CRDs, CSVs, and config files for hypershift plugin support

Reviewed Changes

Copilot reviewed 30 out of 31 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/e2e/sample-applications/hostedcontrolplanes/hypershift/hostedcluster-pull-secret.yaml	Added YAML for pull secret with hypershift label
tests/e2e/sample-applications/hostedcontrolplanes/hypershift/hostedcluster-etcd-enc-key.yaml	Added YAML for etcd encryption key with hypershift label
tests/e2e/sample-applications/hostedcontrolplanes/hypershift/hostedcluster-agent-capi-role.yaml	Added YAML Role for agent with capi access
tests/e2e/lib/scheme.go	Registered hypershift API scheme
tests/e2e/lib/backup.go	Added function CreateCustomBackupForNamespaces
tests/e2e/lib/apps.go	Logged deployment status for debugging
tests/e2e/hcp_backup_restore_suite_test.go	Introduced the hypershift backup & restore test suite and helper functions
tests/e2e/e2e_suite_test.go	Updated client scheme initialization for test runtime
pkg/credentials/*	Added hypershift related test cases and plugin image logic
pkg/common/common.go	Added hypershift plugin constants
internal/controller/*	Updated unit tests to include hypershift plugin in deployment and nodeagent checks
docs/developer/testing/TESTING.md	Added env variable for hypershift plugin image
config/*	Updated configuration files with hypershift plugin references
api/v1alpha1/dataprotectionapplication_types.go	Extended enum and constants to include hypershift plugin

Files not reviewed (1)

go.mod: Language not supported

Comments suppressed due to low confidence (1)

tests/e2e/hcp_backup_restore_suite_test.go:25

The variable 'dpaCR' is used without a visible declaration in this file. Please ensure that 'dpaCR' is defined or passed appropriately.

err := lib.AddHCPPluginToDPA(h, dpaCR.Namespace, dpaCR.Name, false)

tests/e2e/hcp_backup_restore_suite_test.go

jparrill · 2025-03-27T22:58:07Z

Need to add coverage: #1676 (comment)

openshift-ci-robot · 2025-03-27T23:04:24Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-27T23:04:31Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-04-02T09:59:12Z

The PR is ready to be reviewed 🚀

config/samples/oadp_v1alpha1_dataprotectionapplication.yaml

mateusoliveira43 · 2025-04-02T13:35:59Z

tests/e2e/lib/scheme.go

whats the why behind this change?

Mostly order and reusability. I think that function could be reused from most of the places and have a dynamic client just calling a function.

tests/e2e/lib/hcp_helpers.go

tests/e2e/hcp_backup_restore_suite_test.go

weshayutin · 2025-04-02T15:18:00Z

@jparrill the typical oadp e2e test expects that OADP will be installed and the dpa is configured. This should also follow that pattern imho if I'm understanding things correctly.

2025/04/02 09:15:16 Preparing backup and restore
  [FAILED] Unexpected error:
      <*meta.NoKindMatchError | 0xc0008fefc0>: 
      no matches for kind "DataProtectionApplication" in version "oadp.openshift.io/v1alpha1"
      {
          GroupKind: {
              Group: "oadp.openshift.io",
              Kind: "DataProtectionApplication",
          },
          SearchedVersions: ["v1alpha1"],
      }
  occurred
  In [It] at:

weshayutin · 2025-04-16T18:45:39Z

We'll start reviewing to merge, but sorry to say we've already branched oadp-1.5 :)

openshift-ci-robot · 2025-04-21T13:30:13Z

@jparrill: This pull request references OADP-5782 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-04-21T17:11:50Z

👍 I will backport to oadp-1.5 branch if needed (in the end it's E2E coverage)

weshayutin · 2025-04-21T19:08:33Z

hrm.. I think the images we're pulling here are NOT multi-arch.

so I have an arm cluster w/ 3 cont, 3 workers.. I think this is the second time trying the hypershipft e2e on this cluster. Is there cleanup, or additional resources I need? Any gotchas?

it's stalling on 2025/04/21 13:02:46 Error getting etcd statefulset, retrying...: statefulsets.apps "etcd" not found
oh.. SOMETHING is not built for ARM64
cluster-api-56b7695c85-4ljdj - exec container process /bin/cluster-api-controller-manager: Exec format error

-1, we need this to work out of the box on ARM64 as that is the only arch we are allowed to devel on in OADP.

weshayutin

Needs to work as written for ARM64

jparrill · 2025-04-21T21:23:56Z

Hey @weshayutin looks like the CAPI image is not being using multi, to solve that is just changing a line: https://github.com/openshift/oadp-operator/pull/1684/files#diff-683c1f305231a8b35496874f630b287ea73c40ff73f633c4d27c9851b798c977R28

The question I have is, should I build the plugin in multiarch to make it work in the ARM cluster, or just change the OCP payload to use multiarch?

kaovilai · 2025-04-21T23:18:05Z

either works if it works. ideally the upstream quay plugin for devs will also be multi arch so we don't have to override when on diff arches.

tests/e2e/lib/hcp/types.go

Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>

weshayutin · 2025-04-22T14:38:45Z

the deployments and b/r are working, but I do see 2 velero pods running and 1 in crash loop

 oc get all -n openshift-adp
Warning: apps.openshift.io/v1 DeploymentConfig is deprecated in v4.14+, unavailable in v4.10000+
NAME                                                                  READY   STATUS                  RESTARTS      AGE
pod/21c451aa53ee024e6269633beb465ea4e32b6303fbc892011ab1e77c65c68zt   0/1     Completed               0             29m
pod/node-agent-7pzxg                                                  1/1     Running                 0             2m59s
pod/node-agent-lx7gx                                                  1/1     Running                 0             2m59s
pod/node-agent-sjlj4                                                  1/1     Running                 0             2m59s
pod/openshift-adp-controller-manager-54b454dbc4-nxdtn                 1/1     Running                 0             29m
pod/ttl-sh-oadp-operator-bundle-300e7d1e-1h                           1/1     Running                 0             30m
pod/velero-57cfdf6bc5-8m9ts                                           0/1     Init:CrashLoopBackOff   4 (61s ago)   2m44s
pod/velero-84787d6799-rhtzx                                           1/1     Running                 0             2m59s

NAME                                                       TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
service/openshift-adp-controller-manager-metrics-service   ClusterIP   172.30.177.205   <none>        8443/TCP   29m
service/openshift-adp-velero-metrics-svc                   ClusterIP   172.30.199.182   <none>        8085/TCP   2m59s

NAME                        DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
daemonset.apps/node-agent   3         3         3       3            3           kubernetes.io/os=linux   2m59s

NAME                                               READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/openshift-adp-controller-manager   1/1     1            1           29m
deployment.apps/velero                             1/1     1            1           2m59s

NAME                                                          DESIRED   CURRENT   READY   AGE
replicaset.apps/openshift-adp-controller-manager-54b454dbc4   1         1         1       29m
replicaset.apps/velero-57cfdf6bc5                             1         1         0       2m44s
replicaset.apps/velero-84787d6799                             1         1         1       2m59s

NAME                                                                        STATUS     COMPLETIONS   DURATION   AGE
job.batch/21c451aa53ee024e6269633beb465ea4e32b6303fbc892011ab1e77c65bff52   Complete   1/1           8s         29m
whayutin@thinkdoe:~/OPENSHIFT/git/OADP/oadp-operator$ ^C
whayutin@thinkdoe:~/OPENSHIFT/git/OADP/oadp-operator$ oc logs -f pod/velero-57cfdf6bc5-8m9ts
Defaulted container "velero" out of: velero, openshift-velero-plugin (init), velero-plugin-for-aws (init), hypershift-oadp-plugin (init)
Error from server (BadRequest): container "velero" in pod "velero-57cfdf6bc5-8m9ts" is waiting to start: PodInitializing
whayutin@thinkdoe:~/OPENSHIFT/git/OADP/oadp-operator$

Perhaps just my deployment.. will retry..

First test: test-hc-none

Hypershift nested cluster deployed successfully
backup: https://termbin.com/v9sm
deleted
restored: https://termbin.com/bv68
nested cluster came up .. WOOT!

Second test: test-hc-agent

cluster deployed
backup completed: https://termbin.com/jexe
cluster terminated
restore completed: https://termbin.com/r1kn
cluster test-hc-agent displayed ready, but had errors.

Errors bringing up: test-hc-agent cluster

	-
ClusterVersionSucceeding
Multiple errors are preventing progress: * Cluster operators console, dns, image-registry, ingress, insights, kube-storage-version-migrator, monitoring, network, node-tuning, openshift-samples, service-ca are not available * Could not update imagestream "openshift/driver-toolkit" (440 of 613): resource may have been deleted * Could not update operatorgroup "openshift-monitoring/openshift-cluster-monitoring" (554 of 613): resource may have been deleted * Could not update role "openshift-authentication/prometheus-k8s" (541 of 613): resource may have been deleted * Could not update role "openshift-console-operator/prometheus-k8s" (571 of 613): resource may have been deleted * Could not update role "openshift-console/prometheus-k8s" (575 of 613): resource may have been deleted * Could not update role "openshift-ingress-operator/prometheus-k8s" (582 of 613): resource may have been deleted * Could not update role "openshift-kube-apiserver-operator/prometheus-k8s" (586 of 613): resource may have been deleted
ClusterVersionProgressing
Unable to apply 4.18.6: an unknown error has occurred: MultipleErrors

csi-snapshot-controller on test-hc-agent

I0422 14:31:55.567158 1 feature_gate.go:387] feature gates: {map[]}
I0422 14:31:55.567518 1 main.go:169] Version: v4.18.0-202503121135.p0.g838d248.assembly.stream.el9-0-g0b14479-dirty
I0422 14:31:55.569892 1 main.go:220] Start NewCSISnapshotController with kubeconfig [/etc/kubernetes/kubeconfig] resyncPeriod [15m0s]
E0422 14:31:55.573265 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:55.683419 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:55.837292 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:56.064346 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:56.407941 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:56.923326 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:57.695166 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:31:58.837434 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:32:00.548855 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:32:03.114404 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:32:06.960782 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:32:12.729498 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:32:21.382084 1 main.go:98] Failed to list v1 volumesnapshots with error=Get "https://kube-apiserver:6443/apis/snapshot.storage.k8s.io/v1/volumesnapshots?limit=1": dial tcp 172.30.42.230:6443: connect: connection refused
E0422 14:32:25.574252 1 main.go:246] Exiting due to failure to ensure CRDs exist during startup: context deadline exceeded

@jparrill this is pretty cool stuff, impressive and well done. Can you please check out these errors on the second test. It seems like not all the services came up on the test-hc-agent cluster, is that to be expected?

Ran 2 of 39 Specs in 2577.469 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 37 Skipped
PASS

Ginkgo ran 1 suite in 43m2.896104328s
Test Suite Passed

jparrill · 2025-04-22T14:44:29Z

/test 4.19-e2e-test-hcp-aws-periodic

works now

jparrill · 2025-04-23T09:30:21Z

I think this could be a flakiness on the restoration part. I think it's worth to:

Got this merged
Fix the release repo to have periodics and presubmit correctly set
Add a new PR to oadp-operator repo to pin a concrete version of the plugin instead of use latest
Enhance the E2E with more strict rules and put countermeasures to fix the flakiness

Regarding the Multiarch part:

We have already merged the multiarch binaries generation with goreleaser.
We are working on the Konflux pipelines to have the multiarch images properly generated and published in our repo namespace.

I think with these things we have all the fronts covered. WDYT @weshayutin @kaovilai ?

kaovilai · 2025-04-23T12:15:46Z

Sound good to me

kaovilai · 2025-04-23T16:12:39Z

/lgtm

openshift-ci · 2025-04-23T16:48:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-04-23T19:30:18Z

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

weshayutin · 2025-04-24T00:59:35Z

@jparrill @kaovilai so will this cherry pick to oadp-1.5?? Or is that a fresh PR?

jparrill · 2025-04-24T07:59:54Z

/jira backport oadp-1.5

openshift-ci-robot · 2025-04-24T07:59:56Z

@jparrill: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick oadp-1.5

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-04-24T08:00:34Z

@openshift-ci-robot: #1684 failed to apply on top of branch "oadp-1.5":

Applying: OADP-5782: Add hypershift-oadp-plugin E2E tests
Using index info to reconstruct a base tree...
M	Makefile
M	bundle/manifests/oadp-operator.clusterserviceversion.yaml
M	go.mod
M	go.sum
M	tests/e2e/e2e_suite_test.go
M	tests/e2e/lib/apps.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/lib/apps.go
Auto-merging tests/e2e/e2e_suite_test.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
Auto-merging bundle/manifests/oadp-operator.clusterserviceversion.yaml
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OADP-5782: Add hypershift-oadp-plugin E2E tests

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025

jparrill changed the title ~~Oadp 5782 e2 e~~ OADP-5782: Add hypershift-oadp-plugin E2E tests Mar 27, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025

jparrill force-pushed the OADP-5782-E2E branch from 37c9996 to 5e053ef Compare March 27, 2025 20:08

kaovilai requested a review from Copilot March 27, 2025 22:49

Copilot AI reviewed Mar 27, 2025

View reviewed changes

tests/e2e/hcp_backup_restore_suite_test.go Show resolved Hide resolved

jparrill force-pushed the OADP-5782-E2E branch 4 times, most recently from 56e0c6a to 3df12fd Compare April 2, 2025 09:54

jparrill marked this pull request as ready for review April 2, 2025 09:59

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025

openshift-ci bot requested review from savitharaghunathan and shubham-pampattiwar April 2, 2025 09:59

mateusoliveira43 reviewed Apr 2, 2025

View reviewed changes

config/samples/oadp_v1alpha1_dataprotectionapplication.yaml Show resolved Hide resolved

mateusoliveira43 reviewed Apr 2, 2025

View reviewed changes

tests/e2e/lib/hcp_helpers.go Outdated Show resolved Hide resolved

mateusoliveira43 reviewed Apr 2, 2025

View reviewed changes

tests/e2e/hcp_backup_restore_suite_test.go Show resolved Hide resolved

jparrill mentioned this pull request Apr 3, 2025

CNTRLPLANE-358: Add HCP E2E presubmit and periodics openshift/release#63478

Merged

jparrill force-pushed the OADP-5782-E2E branch from 3df12fd to 63cd50c Compare April 3, 2025 12:26

weshayutin previously requested changes Apr 21, 2025

View reviewed changes

shubham-pampattiwar reviewed Apr 21, 2025

View reviewed changes

tests/e2e/lib/hcp/types.go Outdated Show resolved Hide resolved

tests/e2e/lib/hcp/types.go Outdated Show resolved Hide resolved

jparrill force-pushed the OADP-5782-E2E branch from 97a628a to da7e5a3 Compare April 22, 2025 08:19

OADP-5782: Add hypershift-oadp-plugin E2E tests

300e7d1

Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>

jparrill force-pushed the OADP-5782-E2E branch from da7e5a3 to 300e7d1 Compare April 22, 2025 10:43

weshayutin approved these changes Apr 23, 2025

View reviewed changes

openshift-ci bot assigned kaovilai Apr 23, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025

weshayutin added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025

kaovilai approved these changes Apr 23, 2025

View reviewed changes

openshift-merge-bot bot merged commit 4ab8b14 into openshift:master Apr 23, 2025
9 checks passed

jparrill mentioned this pull request Apr 24, 2025

[oadp-1.5] OADP-5782: Add hypershift-oadp-plugin as a default one in oadp-operator + E2E #1729

Merged

OADP-5782: Add hypershift-oadp-plugin E2E tests #1684

OADP-5782: Add hypershift-oadp-plugin E2E tests #1684

Uh oh!

Conversation

jparrill commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

openshift-ci bot commented Mar 27, 2025

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

jparrill commented Mar 27, 2025

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

openshift-ci-robot commented Mar 27, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

jparrill commented Apr 2, 2025

Uh oh!

Uh oh!

mateusoliveira43 Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

jparrill Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

weshayutin commented Apr 2, 2025

Uh oh!

weshayutin commented Apr 16, 2025

Uh oh!

openshift-ci-robot commented Apr 21, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why the changes were made

How to test the changes made

Uh oh!

jparrill commented Apr 21, 2025

Uh oh!

weshayutin commented Apr 21, 2025

Uh oh!

weshayutin left a comment

Choose a reason for hiding this comment

Uh oh!

jparrill commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaovilai commented Apr 21, 2025

jparrill commented Mar 27, 2025 •

edited

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 27, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 21, 2025 •

edited by openshift-ci bot

Loading

jparrill commented Apr 21, 2025 •

edited

Loading

weshayutin commented Apr 22, 2025 •

edited

Loading