Skip to content

Redirect users to oc-explain for references. #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2023

Conversation

kaovilai
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@weshayutin
Copy link
Contributor

@kaovilai for stable branches 1.1, 1.2 imho we should build on your original idea.
https://github.com/weshayutin/oadp-operator/blob/wes_api_doc/docs/API_ref.md

Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai force-pushed the kaovilai-API_ref-redirect-oc-explain branch from 52cddc7 to 81aa083 Compare April 25, 2023 19:38
@openshift-ci
Copy link

openshift-ci bot commented Apr 25, 2023

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai
Copy link
Member Author

/hold

Need to discuss if we wanna output everything into .md for stable.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@kaovilai
Copy link
Member Author

Consider using kubernetes/kubectl#1419 when its implemented.

@kaovilai
Copy link
Member Author

For master I think this is good, but may want to add a script to makefile here for use in generating in other branches.

@weshayutin
Copy link
Contributor

weshayutin commented Apr 28, 2023

@kaovilai will https://pkg.go.dev/github.com/openshift/oadp-operator@master render after this is merged?
doesn't look like it to me..
guess we need to point at a release not a branch
https://pkg.go.dev/github.com/openshift/oadp-operator?tab=versions

The rest of the change looks good, and thank you!

@kaovilai
Copy link
Member Author

@weshayutin https://pkg.go.dev/github.com/openshift/oadp-operator@master is now rendering.

After awhile the cache is deleted, and you have to request the page.

@weshayutin
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2023
@kaovilai
Copy link
Member Author

kaovilai commented May 1, 2023

Although other branch names (oadp-1.0, etc.) do not work for pkgsite. but we can work around that by generating a tagged version.
golang/go#46914

@weshayutin weshayutin merged commit 15587ad into master May 16, 2023
@weshayutin weshayutin deleted the kaovilai-API_ref-redirect-oc-explain branch May 16, 2023 18:32
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants