-
Notifications
You must be signed in to change notification settings - Fork 80
Redirect users to oc-explain for references. #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kaovilai for stable branches 1.1, 1.2 imho we should build on your original idea. |
Signed-off-by: Tiger Kaovilai <[email protected]>
52cddc7
to
81aa083
Compare
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold Need to discuss if we wanna output everything into .md for stable. |
Consider using kubernetes/kubectl#1419 when its implemented. |
For master I think this is good, but may want to add a script to makefile here for use in generating in other branches. |
@kaovilai will https://pkg.go.dev/github.com/openshift/oadp-operator@master render after this is merged? The rest of the change looks good, and thank you! |
@weshayutin https://pkg.go.dev/github.com/openshift/oadp-operator@master is now rendering. After awhile the cache is deleted, and you have to request the page. |
/unhold |
Although other branch names (oadp-1.0, etc.) do not work for pkgsite. but we can work around that by generating a tagged version. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.