Skip to content

no-jira: OWNERS: add Krzys (ibihim) and Ilias (liouk) as reviewers #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

no-jira: OWNERS: add Krzys (ibihim) and Ilias (liouk) as reviewers #282

merged 1 commit into from
Jan 9, 2025

Conversation

ibihim
Copy link

@ibihim ibihim commented Sep 3, 2024

What

Add to owners:

  • ibihim
  • liouk

Remove from owners:

  • sttts
  • stlaz

Why

sttts and stlaz left the org. ibihim and liouk are the current maintainers.

@openshift-ci openshift-ci bot requested a review from deads2k September 3, 2024 14:46
@deads2k
Copy link

deads2k commented Sep 3, 2024

/lgtm
/approve

@deads2k
Copy link

deads2k commented Sep 3, 2024

/lgtm

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2024
@ibihim
Copy link
Author

ibihim commented Sep 3, 2024

/retest-required

3 similar comments
@ibihim
Copy link
Author

ibihim commented Sep 4, 2024

/retest-required

@ibihim
Copy link
Author

ibihim commented Sep 6, 2024

/retest-required

@ibihim
Copy link
Author

ibihim commented Sep 18, 2024

/retest-required

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@ingvagabund
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ibihim, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 9, 2025
@ingvagabund
Copy link
Member

/retitle no-jira: OWNERS: add Krzys (ibihim) and Ilias (liouk) as reviewers

@openshift-ci openshift-ci bot changed the title OWNERS: add Krzys (ibihim) and Ilias (liouk) as reviewers no-jira: OWNERS: add Krzys (ibihim) and Ilias (liouk) as reviewers Jan 9, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2025
@openshift-ci-robot
Copy link

@ibihim: This pull request explicitly references no jira issue.

In response to this:

What

Add to owners:

  • ibihim
  • liouk

Remove from owners:

  • sttts
  • stlaz

Why

sttts and stlaz left the org. ibihim and liouk are the current maintainers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 9, 2025

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ab5ee48 into openshift:master Jan 9, 2025
7 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: golang-github-openshift-oauth-proxy
This PR has been included in build golang-github-openshift-oauth-proxy-container-v4.19.0-202501091837.p0.gab5ee48.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@ingvagabund ingvagabund

@deads2k deads2k

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ibihim @deads2k @openshift-bot @ingvagabund @openshift-ci-robot