pkg/cli/admin/inspect/namespace: Gather PDBs too #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pod disruption budgets are important enough to be included in Insights tarballs [1], and they aren't all that big, so we should pick them up as a standard part of interesting namespaces too. This will help with things like auditing issues where we failed to drain (PDB too strict) or disrupted a core workload (PDB too weak or missing). [1]: openshift/insights-operator#185
|
Success (in the part relative to this change): $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_oc/750/pull-ci-openshift-oc-master-e2e-aws/1365031549019361280/artifacts/e2e-aws/gather-must-gather/artifacts/must-gather.tar | tar xOz ./registry-build02-ci-openshift-org-ci-op-9s0tkctb-stable-sha256-6d3b3b27072a08a0c6606155d61e771a64caec6b5ee1a4cae6a9d843fdc19d20/namespaces/openshift-etcd/policy/poddisruptionbudgets.yaml
---
apiVersion: policy/v1beta1
items:
- apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
creationTimestamp: "2021-02-25T20:47:48Z"
... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
added a commit
to wking/hypershift
that referenced
this pull request
Dec 1, 2023
Pod disruption budgets are important enough to be included in Insights tarballs [1], and they aren't all that big, so we should pick them up as a standard part of interesting namespaces too. This will help with things like auditing issues where we failed to drain (PDB too strict) or disrupted a core workload (PDB too weak or missing). Similar to openshift/oc@c32fac0143 (pkg/cli/admin/inspect/namespace: Gather PDBs too, 2021-03-03, openshift/oc#750). [1]: openshift/insights-operator#185
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pod disruption budgets are important enough to be included in Insights tarballs (openshift/insights-operator#185), and they aren't all that big, so we should pick them up as a standard part of interesting namespaces too. This will help with things like auditing issues where we failed to drain (PDB too strict) or disrupted a core workload (PDB too weak or missing).