-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document how to use the SYN eater iptables change to protect router reloads #1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reload window. However, doing so means that the router needs to run | ||
with elevated privilege so that it can manipulate *_iptables_* on the | ||
host. It also means that connections that happen during the reload | ||
are temporarily ignorred and will have to retransmit their connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ignored"
@adellape PTAL |
@@ -609,6 +609,58 @@ $ echo " router metrics at: http://<ip>:9090/consoles/haproxy.html " | |||
==== | |||
|
|||
|
|||
=== Preventing Connection Failures During Restarts === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the concluding === in the heading (we only need the ones in the beginning)
@knobunc just a few minor comments. Looks like we also need a rebase 🙇 Also, is this for 3.3 (future release)? Thanks! |
…eloads This documents the steps needed to enable the SYN eater to prevent connection drops when the haproxy used by the router reloads. In order to work its magic it needs to use iptables, which entails all sorts of fussing to get the router user to have the needed permissions, and to patch the deployment config to make it request a privileged container.
@ahardin-rh Thanks for the review. This is for 3.2. |
@knobunc Thanks! |
[rev_history] |
@@ -1030,6 +1030,57 @@ $ echo " router metrics at: http://<ip>:9090/consoles/haproxy.html " | |||
==== | |||
|
|||
|
|||
=== Preventing Connection Failures During Restarts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unique ID.
@ahardin-rh Made a few comments to you for a follow-up PR. Moving this back to Next Release w/ a |
@adellape Thanks! Good catches. Created a follow-up PR. |
This documents the steps needed to enable the SYN eater to prevent
connection drops when the haproxy used by the router reloads. In
order to work its magic it needs to use iptables, which entails all
sorts of fussing to get the router user to have the needed
permissions, and to patch the deployment config to make it request a
privileged container.