-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1354145, added Using a Router Image to Protect Against DDoS Attacks #2564
Conversation
@JacobTanenbaum Please review. Also, what are your thoughts on placement? Thanks! |
I think this should be moved to the section "Deploying the default haproxy router". PR openshift/origin#9003 adds an environment variable (ROUTER_SLOWLORIS_TIMEOUT) to toggle defending the system against slow loris like attacks. I am also not sure exactly the best place to mention them but PR openshift/origin#9810 adds the ability to defend routes from various other DDoS type attacks, the annotations on the route affect the routes backend in the router template |
@JacobTanenbaum Thanks for your suggestions! I captured the extra information you provided and also moved the content per your comments. What are the benefits of setting timeout http-request vs. ROUTER_SLOWLORIS_TIMEOUT vs. the outlined HAProxy Template Router Settings? I think it would be helpful to provide a use case for each, or at least provide more clarity as to why a user would choose one method over the other. Thoughts? Thanks again! |
|
||
|Setting |Description | ||
|
||
|`*router.openshift.io/haproxy.DDOS*` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haproxy.router.openshift.io/rate-limit-connections
setting the environment variable has the benefit of being part of the router template. The information is captured as part of the routers deployment configuration and does not require a user to hand modify the template. |
@JacobTanenbaum Thanks for your comments. This is now updated. @adellape @tnguyen-rh Please peer review 🙇 |
|
||
Also, when the environment variable `*ROUTER_SLOWLORIS_TIMEOUT*` is set, it | ||
limits the amount of time a client has to send the whole HTTP request. | ||
Otherwise, HAProxy will shut down the connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe redundant in the current context, but i'd conditionalize the last sentence: "Otherwise, ... the connection, if CONDITION."
@ahardin-rh A few stumbling points for me. |
4355741
to
a2a93aa
Compare
a2a93aa
to
fe79def
Compare
Approved by QE in BZ |
[rev_history] |
https://bugzilla.redhat.com/show_bug.cgi?id=1354145