Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up edits to PR#2596 #2657

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Conversation

ahardin-rh
Copy link
Contributor

Follow-up to #2596

@ahardin-rh ahardin-rh added this to the Future Release milestone Aug 16, 2016
@ahardin-rh ahardin-rh self-assigned this Aug 16, 2016
@ahardin-rh
Copy link
Contributor Author

@adellape @bfallonf @tpoitras please peer review 🙇

====
----
$ oc create clusterquota for-user --project-annotation-selector openshift.io/requester=<user-name> --hard pods=10 --hard secrets=20
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe break this up w/ backslashes? E.g.,

$ oc create clusterquota for-user \
    --project-annotation-selector openshift.io/requester=<user-name> \
    --hard pods=10 \
    --hard secrets=20

@adellape
Copy link
Contributor

@ahardin-rh Comments inline, otherwise 👍

will be aggregated and that aggregate will be used to limit resources across
all the selected projects.
A multi-project quota, defined by a `*ClusterResourceQuota*` object, allows
xref:../admin_guide/quota.adoc#admin-guide-quota[quota] to be shared across

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the plural for quota is quotas, so either:

s/quota/a quota or s/quota/quotas

That does depend on if you can share one quota object over multiple projects, I guess...

@bfallonf
Copy link

@ahardin-rh Just one comment from me. ⭐ otherwise!

@ahardin-rh
Copy link
Contributor Author

@adellape @bfallonf Thanks for the peer review. All fixed 🎆

@ahardin-rh ahardin-rh merged commit c4a3108 into openshift:master Aug 17, 2016
@ahardin-rh
Copy link
Contributor Author

Rev history in original PR

@vikram-redhat vikram-redhat modified the milestones: OCP 3.3 GA, TEMP Oct 7, 2016
@ahardin-rh ahardin-rh deleted the followup-PR2596 branch November 30, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants