Bug 1381336, deploy metrics as the deployer service account. #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adellape If you could take a look that would be greatly appreciated. This affects 3.3 and we have already had 2 bugzillas open about this. |
|
@adellape any update on this? This really needs to be updated because its affecting customers in 3.3 |
ahardin-rh
changed the title
|
@mwringe LGTM. Thanks! Flipping to QE in the BZ. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1381336 where the user who deploys metrics could have special scc permissions which could prevent the deployer from functioning properly.
The deployer service account is the more correct user to be handling the deployer pod.