Skip to content

BZ: 1383903. Notes and changes for for logging stack upgrade #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

danmacpherson
Copy link

Also includes PR #3172

@vikram-redhat -- Ready to review and merge

@vikram-redhat
Copy link
Contributor

@ahardin-rh - Please review.

@vikram-redhat vikram-redhat changed the title Notes and changes for for logging stack upgrade BZ: 1383903. Notes and changes for for logging stack upgrade Nov 14, 2016
@vikram-redhat vikram-redhat added this to the Future Release milestone Nov 14, 2016
@@ -1370,6 +1370,26 @@ of Fluentd pods, the deployer does delete the *logging-fluentd* Daemonset and re
it from the *logging-fluentd-template* template.
====

The latest EFK stack now uses Elasticsearch 2.3 with a common data model. This
means Fluentd sends logs to Elasticsearch with a new indexing pattern for
projects. The pattern is:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should call out that the pattern for 'operations' logs will stay the same.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note for the operations logs.

[IMPORTANT]
====
Downgrading from Elasticsearch 2.3 to Elasticsearch 1.x is not possible due to
migration to the new data model.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is independent of the common data model; this is simply a limitation of Elasticsearch 1.x not being able to interpret the data structure of ES 2.x.

It may not be necessary to capture that in the documentation, however it should be noted.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've modified this from "data model" to "data structure" to avoid confusion.

@ewolinetz
Copy link

LGTM

@ahardin-rh
Copy link
Contributor

@danmacpherson @vikram-redhat I merged some logging content today because I did not know this work was being done:
#3172
#3223

Hopefully, a simple rebase resolves this. If not, we can always revert the changes I introduced. Just a heads-up. As we approach 3.4, I am trying to knock out some dev-submitted PRs so I recommend using the "assign yourself" function to prevent team members from bumping into eachother. Thanks!

@vikram-redhat
Copy link
Contributor

@ahardin-rh - thanks. A simple rebase should solve this.

@adellape
Copy link
Contributor

@ewolinetz @danmacpherson Does this PR need to take #3081 (comment) into consideration?

@ewolinetz
Copy link

@adellape yes, it should have this line[1] added to it, similar to step 4 in the manual upgrades for EFK.

[1] 12f52aa#diff-0bd2e2c1a5da6f157682d4e95ecea473R145

@danmacpherson danmacpherson force-pushed the BZ1383903-LoggingStack branch 2 times, most recently from 481315e to e3b7ad2 Compare November 22, 2016 05:39
@danmacpherson
Copy link
Author

Rebased the branch and merged #3172 and #3223. Have also cherry-picked 1548139 from ewolinetz:allow_cluster_reader_logging and made some minor edits. I don't think there are any more conflicts with openshift-docs/master now.

Adding suggestions from ewolinetz

Adding suggestions from ewolinetz

Updating install documentation and adding information on how to allow cluster-reader to view operations logs

Follow-up to ewolinet's notes on 'rolebinding-reader'
@danmacpherson
Copy link
Author

Squashed the commits to accommodate our publishing system

@vikram-redhat
Copy link
Contributor

Since peer and tech review has passed, I am merging this.

@vikram-redhat vikram-redhat merged commit 7de9ee9 into openshift:master Nov 28, 2016
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.4 GA Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants