Bug 1384018: New "Kubernetes Deployments Support" topic #3255

adellape · 2016-11-18T21:17:31Z

https://bugzilla.redhat.com/show_bug.cgi?id=1384018

Cherry-picks #3205 and builds on it.

Preview:

http://file.rdu.redhat.com/~adellape/111816/kubernetes-deployments/dev_guide/deployments/kubernetes_deployments.html

adellape · 2016-11-18T21:23:23Z

@ahardin-rh PTAL 🙇‍♀️

ahardin-rh · 2016-11-18T21:36:21Z

dev_guide/deployments/kubernetes_deployments.adoc

+
+- xref:../../dev_guide/managing_images.adoc#dev-guide-managing-images[image streams]
+- xref:../../dev_guide/deployments/deployment_strategies.html#lifecycle-hooks[lifecycle hooks]
+- xref:../../dev_guide/deployments/deployment_strategies.html#custom-strategy[Custom deployment strategies]


Custom is capitalized here, but "image" and lifestyle" are not.

I capitalized it since we capitalize it in the doc it links to, as the type of strategy. I could go either way here.

ahardin-rh · 2016-11-18T21:38:29Z

dev_guide/deployments/kubernetes_deployments.adoc

+$ oc rollout pause deployments/<name>
+----
+
+At the moment, upstream Deployment do not support ImageChange triggers. A generic triggering


s/Deployment/deployments

Oops I missed this paragraph completely.

ahardin-rh · 2016-11-18T21:39:33Z

dev_guide/deployments/kubernetes_deployments.adoc

+----
+
+At the moment, upstream Deployment do not support ImageChange triggers. A generic triggering
+mechanism has been proposed upstream but it is unknown if and when will it be accepted.


upstream, but

ahardin-rh · 2016-11-18T21:39:51Z

dev_guide/deployments/kubernetes_deployments.adoc

+----
+
+At the moment, upstream Deployment do not support ImageChange triggers. A generic triggering
+mechanism has been proposed upstream but it is unknown if and when will it be accepted.


s/will it/it will

ahardin-rh · 2016-11-18T21:43:59Z

dev_guide/deployments/kubernetes_deployments.adoc

+
+At the moment, upstream Deployment do not support ImageChange triggers. A generic triggering
+mechanism has been proposed upstream but it is unknown if and when will it be accepted.
+Eventually, we can implement our own mechanism on top but it would be more desirable for it


maybe reword this sentence to focus on "you" instead of "we". Also, the "on top" is confusing. Perhaps reword to:

Eventually, you will be able to implement your own mechanism. However, it is more desirable to have this exist as part of the Kubernetes core.

ahardin-rh · 2016-11-18T21:44:39Z

dev_guide/deployments/kubernetes_deployments.adoc

+[[dc-vs-d-custom-strategies]]
+==== Custom Strategies
+
+Kubernetes deployments do not yet support user-specified Custom deployment


s/Custom/custom

ahardin-rh · 2016-11-18T21:47:54Z

@adellape Just a few comments from me. Looks good overall!

adellape · 2016-11-18T22:25:23Z

@ahardin-rh Thanks, edits made.

@Kargakis @mfojtik PTAL. Preview:

http://file.rdu.redhat.com/~adellape/111816/kubernetes-deployments/dev_guide/deployments/kubernetes_deployments.html

Some notes on my thinking here:

Went with calling the object "Kubernetes deployments" to differentiate it from deployment configurations, but without simply calling it "deployments". Also prefered it over "upstream deployments". At some point in the future after deployments evolves further (and it comes out of Tech Preview), I figure we can at that point do the work to unify on deployments throughout the docs over deploymentConfigs, and call them simply "deployments".
Named the topic "Kubernetes Deployments Support" instead of simply "Kubernetes Deployments" since the content seemed to mostly talk about the state of deployments vs deploymentConfigs (e.g., discussing the inside baseball of Kube and OpenShift development goals), rather than actual usage (which the linked-to Kubernetes documentation goes into further).

adellape · 2016-11-18T22:28:40Z

cli_reference/basic_cli_operations.adoc

@@ -107,6 +107,7 @@ syntax:
 |`build` |
 |`buildConfig` | `bc`
 |`deploymentConfig` | `dc`
+|`deployments` (Technology Preview)|


@Kargakis Correct that there's no abbreviation for this?

In 3.3 there is none, in 3.4 there is deploy.

OK thanks, since this PR is for 3.4, I'll add deploy as the abbreviation here.

adellape · 2016-11-18T22:29:10Z

cli_reference/basic_cli_operations.adoc

@@ -117,6 +118,7 @@ syntax:
 |`pod` |`po`
 |`ResourceQuota` | `quota`
 |`replicationController` |`rc`
+|`replicaSet` (Technology Preview)|`rs`


@Kargakis Correct to say that replica sets are also Tech Preview, if deployments are?

Not sure about that, @smarterclayton ?

Ah I see replica sets listed as Tech Preview in Origin 1.3 here:

https://github.com/openshift/origin#alpha-and-unsupported-kubernetes-features

adellape · 2016-11-18T22:29:52Z

dev_guide/deployments/kubernetes_deployments.adoc

+        image: nginx:1.7.9
+        ports:
+        - containerPort: 80
+----


@Kargakis This example is from the Kube deployments doc. Is there another one you'd suggest using instead?

No, it's fine. I would change the name from "nginx-deployment" to "nginx".

0xmichalis · 2016-11-21T09:15:49Z

LGTM

adellape · 2016-11-21T19:09:48Z

Latest edits made and QE sign-off in BZ. Merging.

adellape · 2016-11-21T19:17:06Z

[rev_history]
|xref:../dev_guide/deployments/kubernetes_deployments.adoc#dev-guide-kubernetes-deployments-support[Deployments -> Kubernetes Deployments Support]
|New topic detailing Technology Preview support for the new Kubernetes-provided deployments object type.
%

0xmichalis · 2016-11-22T11:43:30Z

Thanks!

adellape added branch/dedicated branch/enterprise-3.4 branch/online labels Nov 18, 2016

adellape added this to the Future Release milestone Nov 18, 2016

adellape changed the title ~~New "Kubernetes Deployments Support" topic~~ Bug 1384018: New "Kubernetes Deployments Support" topic Nov 18, 2016

adellape force-pushed the kubernetes-deployments branch from 0c90110 to 913ebd6 Compare November 18, 2016 21:19

ahardin-rh reviewed Nov 18, 2016

View reviewed changes

adellape force-pushed the kubernetes-deployments branch 3 times, most recently from 19a9038 to fc0547e Compare November 18, 2016 22:18

adellape force-pushed the kubernetes-deployments branch from fc0547e to 386ebbc Compare November 18, 2016 22:27

adellape commented Nov 18, 2016

View reviewed changes

New "Kubernetes Deployments Support" topic

1c2f0a4

adellape force-pushed the kubernetes-deployments branch from 386ebbc to 1c2f0a4 Compare November 21, 2016 19:03

adellape merged commit 5808a32 into openshift:master Nov 21, 2016

0xmichalis mentioned this pull request Dec 2, 2016

[WIP] Kubernetes deployments #3205

Closed

vikram-redhat modified the milestones: Future Release, Staging, OCP 3.4 GA Jan 16, 2017

adellape modified the milestones: OCP 3.4 GA, Staging, Temp Feb 1, 2017

vikram-redhat modified the milestones: OCP 3.4 GA, Dedicated-Staging Mar 31, 2017

adellape deleted the kubernetes-deployments branch November 9, 2017 20:30

Bug 1384018: New "Kubernetes Deployments Support" topic #3255

Bug 1384018: New "Kubernetes Deployments Support" topic #3255

Uh oh!

Conversation

adellape commented Nov 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adellape commented Nov 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahardin-rh commented Nov 18, 2016

Uh oh!

adellape commented Nov 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adellape Nov 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xmichalis commented Nov 21, 2016

Uh oh!

adellape commented Nov 21, 2016

Uh oh!

adellape commented Nov 21, 2016

Uh oh!

0xmichalis commented Nov 22, 2016

Uh oh!

Uh oh!

adellape commented Nov 18, 2016 •

edited

Loading

adellape Nov 21, 2016 •

edited

Loading