-
Notifications
You must be signed in to change notification settings - Fork 1.8k
set env vars on oc new-app of template #3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm but merge needs to wait for the actual new-app updates. |
sounds great - thanks @bparees fyi - the code changes are openshift/origin#12048 I pulled in @csrwng (dividing up PR reviews, etc.) |
The code changes have merged. @openshift/team-documentation PTAL |
LGTM. Thanks! |
Adding a to_followup label, as I should make style edits to this page as a whole per our updated style guidelines. I will do that work in a separate PR. |
[rev_history] |
@ahardin-rh Do you think #3389 counts as the follow-up to this one, too? |
@adellape I think I had some extra style edits in mind, so I will keep the to_followup label in place for now and get a PR going soon. |
Follow-up complete. Removing that label. |
@bparees PTAL