Skip to content

set env vars on oc new-app of template #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

gabemontero
Copy link
Contributor

@bparees PTAL

@bparees
Copy link
Contributor

bparees commented Nov 30, 2016

lgtm but merge needs to wait for the actual new-app updates.

@bparees bparees self-assigned this Nov 30, 2016
@gabemontero
Copy link
Contributor Author

sounds great - thanks @bparees

fyi - the code changes are openshift/origin#12048

I pulled in @csrwng (dividing up PR reviews, etc.)

@gabemontero
Copy link
Contributor Author

The code changes have merged.

@openshift/team-documentation PTAL

@ahardin-rh ahardin-rh added this to the Future Release milestone Dec 1, 2016
@ahardin-rh
Copy link
Contributor

LGTM. Thanks!

@ahardin-rh ahardin-rh merged commit 546d2a1 into openshift:master Dec 1, 2016
@ahardin-rh
Copy link
Contributor

ahardin-rh commented Dec 1, 2016

Adding a to_followup label, as I should make style edits to this page as a whole per our updated style guidelines. I will do that work in a separate PR.

@gabemontero gabemontero deleted the newAppEnvs branch December 1, 2016 16:53
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../dev_guide/new_app.adoc#dev-guide-new-app[Creating New Applications]
|Noted that any BuildConfig objects created as part of oc new-app processing will not be updated with environment variables passed via the -e|--env argument.
%

@adellape
Copy link
Contributor

@ahardin-rh Do you think #3389 counts as the follow-up to this one, too?

@ahardin-rh
Copy link
Contributor

@adellape I think I had some extra style edits in mind, so I will keep the to_followup label in place for now and get a PR going soon.

@ahardin-rh
Copy link
Contributor

Follow-up complete. Removing that label.

@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.5 GA Apr 12, 2017
@vikram-redhat vikram-redhat modified the milestones: OCP 3.5 GA, Staging May 2, 2017
@vikram-redhat vikram-redhat modified the milestones: Staging, OCP 3.5 GA May 2, 2017
@vikram-redhat vikram-redhat modified the milestones: OCP 3.5 GA, Staging, TEMP Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants