Skip to content

Bug 1403385 added from section to custom builds #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

bfallonf
Copy link

As per: https://bugzilla.redhat.com/show_bug.cgi?id=1403385

@tiwillia can I get an ack this was all you were hoping for for this BZ? Thanks!

@tiwillia
Copy link
Member

Looks great, thanks @bfallonf 🎉

@bfallonf
Copy link
Author

Thanks, @tiwillia

@ahardin-rh @adellape @gaurav-nelson @bmcelvee any thoughts before I merge?

@gaurav-nelson
Copy link
Contributor

@bfallonf ☑️ LGTM

@bfallonf
Copy link
Author

Thanks. I'll merge.

@bfallonf
Copy link
Author

[rev_history]
|xref:../dev_guide/builds.adoc#dev-guide-builds[Builds]
|Added the xref:../dev_guide/builds.adoc#custom-strategy-from[FROM Image] section.
%

@bfallonf bfallonf merged commit 343e505 into openshift:master Dec 20, 2016
@bfallonf bfallonf deleted the from_1403385 branch December 20, 2016 23:17
@gaurav-nelson gaurav-nelson modified the milestones: Next Release, Staging, Published - 09/01/17 Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants