Add quotations mark to scheduled job example #3478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soltysh and @ahardin-rh Could you please take a look? I am updating your PR #3088 |
|
LGTM |
|
That reminds me I need to update docs to use CronJobs instead of ScheduledJobs anywhere after the rebase has landed. |
|
@nak3 Can you please give this a rebase? Thanks! |
|
@ahardin-rh this can be closed, it's already like that in cron_jobs.doc. |
|
@soltysh Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current doc missed the quotations and it doesn't work as this error:
Also, this patch chnaged the
?to*. According to the k8s docs?and*are same meaning, but it should be used consistently.