Skip to content

OSDOCS-2325: release note for ingress controller timeout config #36645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2021
@netlify
Copy link

netlify bot commented Sep 22, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 9cb9773

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61536060286e4b0008cebf8b

😎 Browse the preview: https://deploy-preview-36645--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes

@quarterpin
Copy link

In the doc, the clientTimeout parameter seems missing. The rest looks fine.

@skrthomas
Copy link
Contributor Author

@quarterpin ah, I think a copy/paste error. Thanks for your review!

@quarterpin
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
Copy link
Contributor

@ctauchen ctauchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! A few suggestions for you to consider.

@ctauchen
Copy link
Contributor

@bergerhoffer FYI

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2021

New changes are detected. LGTM label has been removed.

@bergerhoffer bergerhoffer added branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR labels Sep 28, 2021
@bergerhoffer bergerhoffer added this to the Future Release milestone Sep 28, 2021
@bergerhoffer bergerhoffer merged commit 18f9c72 into openshift:enterprise-4.9 Sep 28, 2021
@skrthomas
Copy link
Contributor Author

#33497 (RN Tracker)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants