Skip to content

updates to console RN based on feedback in RN tracker #37333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

opayne1
Copy link
Contributor

@opayne1 opayne1 commented Oct 11, 2021

OSDOCS-2474
RN Tracker

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2021
@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 4082341

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/616458d228b40d0007b8e03b

😎 Browse the preview: https://deploy-preview-37333--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-9-release-notes

@opayne1
Copy link
Contributor Author

opayne1 commented Oct 11, 2021

@yapei I made some edits based on your feedback in the 4.9 release notes tracker. PTAL. Thank you!

@bergerhoffer bergerhoffer added branch/enterprise-4.9 peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 11, 2021
@bergerhoffer bergerhoffer added this to the Future Release milestone Oct 11, 2021
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment unrelated to your changes, so LGTM!

==== Accessing node logs from the *Node Details* page
With this update, admins now have the ability to access node logs from the *Node Details* page. From there, you can switch between individual log files and journal log units in order to inquire about the node.
==== Accessing node logs from the *Node* page
With this update, admins now have the ability to access node logs from the *Node* page. You can switch between individual log files and journal log units in order to inquire about the node by clicking the *Logs* tab.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already like this, but would you mind updating admins to administrators? I wouldn't hold up the PR over this, but in case you have a minute :)

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 11, 2021
@opayne1 opayne1 force-pushed the OSDOCS-2474-updated branch from d00fc6a to 4082341 Compare October 11, 2021 15:31
@yapei
Copy link

yapei commented Oct 12, 2021

thank you for the updates, now looks good to me

@kalexand-rh kalexand-rh merged commit e9f492d into openshift:enterprise-4.9 Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants