Skip to content

Bug 2066860: NFD Outdated spec in NFD documentation under operand #44486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez [email protected]

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2022

@ArangoGutierrez: This pull request references Bugzilla bug 2066860, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2066860: NFD Outdated spec in NFD documentation under operand

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2022
@ArangoGutierrez
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2022

@ArangoGutierrez: This pull request references Bugzilla bug 2066860, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wabouhamad April 11, 2022 20:42
@ArangoGutierrez
Copy link
Contributor Author

/cc @ahardin-rh

@openshift-ci openshift-ci bot requested a review from ahardin-rh April 11, 2022 20:43
@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 321eb0b
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/6254926cb514f60008990253
😎 Deploy Preview https://deploy-preview-44486--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ArangoGutierrez
Copy link
Contributor Author

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@ArangoGutierrez: once the present PR merges, I will cherry-pick it on top of enterprise-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@ahardin-rh ahardin-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once we have QE review, we can merge. Thanks!

@ahardin-rh ahardin-rh added this to the Next Release milestone Apr 19, 2022
@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 19, 2022
@ahardin-rh
Copy link
Contributor

@wabouhamad PTAL. Thanks!

@ahardin-rh ahardin-rh requested review from lenahorsley and removed request for wabouhamad May 10, 2022 15:54
@ahardin-rh
Copy link
Contributor

@lenahorsley Please provide QE review. Thank you!

@lenahorsley
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
Copy link

@wabouhamad wabouhamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ahardin-rh ahardin-rh merged commit f338726 into openshift:main May 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2022

@ArangoGutierrez: All pull requests linked via external trackers have merged:

Bugzilla bug 2066860 has been moved to the MODIFIED state.

In response to this:

Bug 2066860: NFD Outdated spec in NFD documentation under operand

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@ArangoGutierrez: new pull request created: #45553

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #45554

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ahardin-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.10 from head openshift-cherrypick-robot:cherry-pick-44486-to-enterprise-4.10: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-44486-to-enterprise-4.10."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants