Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new section for mount options #4499

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Added a new section for mount options #4499

merged 1 commit into from
Jun 5, 2017

Conversation

gaurav-nelson
Copy link
Contributor

====
Fiber Channel and HostPath persistent volumes do not support mount options.
====

[[persistent-volume-claims]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be rather more exhaustive list of volume types that supports mount-options ? Something like - https://kubernetes.io/docs/concepts/storage/persistent-volumes/#mount-options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnufied
I have updated the PR to include the list of supported PVs.

@gaurav-nelson gaurav-nelson changed the title WIP: Added a new section for mount options [WIP]: Added a new section for mount options May 31, 2017
@gaurav-nelson gaurav-nelson changed the title [WIP]: Added a new section for mount options [WIP] Added a new section for mount options May 31, 2017
@gaurav-nelson
Copy link
Contributor Author

@gnufied
Copy link
Member

gnufied commented May 31, 2017

lgtm!

@gaurav-nelson
Copy link
Contributor Author

Updated to include:

  • Tech Preview warning
  • only available for manually provisioned PVs

@gaurav-nelson gaurav-nelson changed the title [WIP] Added a new section for mount options Added a new section for mount options Jun 2, 2017
@gaurav-nelson
Copy link
Contributor Author

@bfallonf peer review please

persistentVolumeReclaimPolicy: Recycle
claimRef:
name: claim1
namespace: default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurav-nelson I'm not sure, but will the above being one space out from the edge cause problems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bfallonf It rendered fine but I have fixed the extra spaces to be consistent.

@bfallonf
Copy link

bfallonf commented Jun 2, 2017

@gaurav-nelson One comment from me. Looks good otherwise 💯

@gaurav-nelson
Copy link
Contributor Author

[rev_history]
|xref:../architecture/additional_concepts/storage.adoc#architecture-additional-concepts-storage[Persistent Storage]
|Added xref:../architecture/additional_concepts/storage.adoc#pv-mount-options[Mount Options] section.
%

@gaurav-nelson gaurav-nelson merged commit 86f0bec into openshift:master Jun 5, 2017
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging Jul 7, 2017
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.6 GA Aug 9, 2017
@vikram-redhat vikram-redhat modified the milestones: OCP 3.6 GA, Staging Aug 9, 2017
@gaurav-nelson gaurav-nelson deleted the mountOptionsForocp36 branch September 24, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants