-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new section for mount options #4499
Added a new section for mount options #4499
Conversation
==== | ||
Fiber Channel and HostPath persistent volumes do not support mount options. | ||
==== | ||
|
||
[[persistent-volume-claims]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be rather more exhaustive list of volume types that supports mount-options
? Something like - https://kubernetes.io/docs/concepts/storage/persistent-volumes/#mount-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gnufied
I have updated the PR to include the list of supported PVs.
lgtm! |
Updated to include:
|
@bfallonf peer review please |
persistentVolumeReclaimPolicy: Recycle | ||
claimRef: | ||
name: claim1 | ||
namespace: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaurav-nelson I'm not sure, but will the above being one space out from the edge cause problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bfallonf It rendered fine but I have fixed the extra spaces to be consistent.
@gaurav-nelson One comment from me. Looks good otherwise 💯 |
[rev_history] |
For https://trello.com/c/zI33xUyz/419-as-a-openshift-user-i-should-be-able-to-use-mount-options