RHDEVDOCS-3919 - document size-based configuration for Prometheus metrics retention #45007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/M
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Please review this PR and add comments and suggestions as needed. Thank you! |
juzhao
reviewed
Apr 28, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
juzhao
reviewed
Apr 28, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
lihongyan1
reviewed
Apr 28, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
501beab to
7176a38
Compare
openshift-ci
bot
added
size/L
|
@juzhao @lihongyan1 - Please review my updates that address your comments. Thanks! |
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
7176a38 to
6f0db82
Compare
slashpai
reviewed
Apr 29, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
slashpai
reviewed
Apr 29, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
slashpai
reviewed
Apr 29, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
slashpai
reviewed
Apr 29, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
slashpai
reviewed
Apr 29, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
6f0db82 to
b54adb6
Compare
|
@slashpai @juzhao @lihongyan1 - I've revised this PR per your suggestions. Please review. If no further changes are needed, please approve. Thank you! |
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
b54adb6 to
cdbef6a
Compare
lihongyan1
reviewed
May 5, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
cdbef6a to
1f8e428
Compare
|
@slashpai @juzhao @lihongyan1 - I've revised this PR per your most recent suggestions. Please review. If no further changes are needed, please approve with an lgtm. Thank you! |
|
/lgtm |
slashpai
reviewed
May 6, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Show resolved
Hide resolved
rolfedh
reviewed
May 11, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
|
I have completed the OpenShift Docs Peer Review Checklist for this PR. |
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
3ce1374 to
750a42b
Compare
|
New changes are detected. LGTM label has been removed. |
|
@rolfedh I've updated the PR per your suggestions and resolved all conversations. Can you PTAL and approve if you think it's ready? |
rolfedh
approved these changes
May 13, 2022
|
I used the OpenShift Docs Peer Review Checklist to review this PR. |
JStickler
added
dev-tools
JStickler
reviewed
May 13, 2022
modules/monitoring-modifying-retention-time-and-size-for-prometheus-metrics-data.adoc
Outdated
Show resolved
Hide resolved
bburt-rh
force-pushed
the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
from
750a42b to
8bc87d2
Compare
|
/cherry-pick enterprise-4.11 |
|
@JStickler: new pull request created: #45700 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bburt-rh
deleted the
RHDEVDOCS-3919-document-size-based-retention-config-for-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR documents how to configure size-based retention settings for metrics data. Note that only the size-based retention settings content is new in this PR even though GH marks all of the content as new because I renamed an existing file.