-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updating versions to 4.10 instead of 4.9 #45260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pamoedom @hector-vido Just like the 4.8 one (comment here #45259 (comment)) I'm attempting to fix the versions so that 4.9-specific output is changed to 4.10. Please let me know if these changes are sufficient, or if we need to generate new/better output for 4.10. |
✅ Deploy Preview for osdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi guys, is this a problem? I though it was just an example and not the real address, trying to inform the readers about the openshift-install coreos print-stream-json.
Best, |
1a2168f
to
472a3a1
Compare
@pamoedom I took @hector-vido's suggestion to make the output more generic, if we can't just replace the version numbers. Because going forward in the future, that's all we will do (bump versions) - writers won't come back and run commands to get the correct output. I used and as replacement/placeholder values. Can you please take a look and see if this works for you? I've adjusted the 4.8 PR to do the same: https://github.com/openshift/openshift-docs/pull/45259/files |
Thanks @bergerhoffer , LGTM |
Will CP this back to 4.9 as well, since we are using the generic example outputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick enterprise-4.11 |
/cherrypick enterprise-4.10 |
/cherrypick enterprise-4.9 |
@bergerhoffer: new pull request created: #45538 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #45539 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #45540 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Followup to #44319, to fix 4.9 versions to 4.10.
Version(s):
4.9, 4.10, 4.11
Issue:
Link to docs preview:
https://deploy-preview-45260--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_platform_agnostic/installing-platform-agnostic.html#installation-user-infra-machines-iso_installing-platform-agnostic
Additional information: