Skip to content

Updating versions to 4.10 instead of 4.9 #45260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented May 2, 2022

@bergerhoffer bergerhoffer added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.10 branch/enterprise-4.11 labels May 2, 2022
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2022
@bergerhoffer
Copy link
Contributor Author

@pamoedom @hector-vido Just like the 4.8 one (comment here #45259 (comment))

I'm attempting to fix the versions so that 4.9-specific output is changed to 4.10. Please let me know if these changes are sufficient, or if we need to generate new/better output for 4.10.

@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 472a3a1
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62792cf421c537000a0d4e5f
😎 Deploy Preview https://deploy-preview-45260--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hector-vido
Copy link
Contributor

This is the same comment that I wrote in the other PR

Hi guys, is this a problem? I though it was just an example and not the real address, trying to inform the readers about the openshift-install coreos print-stream-json.
Because if we change, we need to change for 4.8, 4.9, 4.10, 4.11 ... and so son.
Another option is remove the versions and use a "template like" output... something like:

./openshift-install coreos print-stream-json | grep '\.iso[^.]'
    "location": "https://<url>/rhcos-4.8-aarch64/<file>-live.aarch64.iso",

Best,

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented May 9, 2022

@pamoedom I took @hector-vido's suggestion to make the output more generic, if we can't just replace the version numbers. Because going forward in the future, that's all we will do (bump versions) - writers won't come back and run commands to get the correct output.

I used and as replacement/placeholder values. Can you please take a look and see if this works for you?

Preview: https://deploy-preview-45260--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_platform_agnostic/installing-platform-agnostic.html#installation-user-infra-machines-iso_installing-platform-agnostic

I've adjusted the 4.8 PR to do the same: https://github.com/openshift/openshift-docs/pull/45259/files

@pamoedom
Copy link

pamoedom commented May 9, 2022

Thanks @bergerhoffer , LGTM
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 9, 2022
@bergerhoffer
Copy link
Contributor Author

Will CP this back to 4.9 as well, since we are using the generic example outputs.

Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@bergerhoffer bergerhoffer merged commit 8dcd377 into openshift:main May 10, 2022
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.11

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.10

@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #45538

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #45539

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #45540

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-needed Signifies that the peer review team needs to review this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants