Skip to content

[SRVKS-892]: Add init container docs #45322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2022
Merged

[SRVKS-892]: Add init container docs #45322

merged 1 commit into from
May 10, 2022

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented May 4, 2022 •
edited
Loading

@abrennan89 abrennan89 added this to the Next Release milestone May 4, 2022
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2022
@netlify
Copy link

netlify bot commented May 4, 2022 •
edited
Loading

✅ Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 5bed27c
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/627acf49d142f80008632f02
😎 Deploy Preview https://deploy-preview-45322--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 4, 2022
@abrennan89 abrennan89 requested a review from skonto May 5, 2022 14:59
mgencur
mgencur reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@mgencur mgencur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one minor note there...

@abrennan89 abrennan89 mentioned this pull request May 9, 2022
Merged
@abrennan89 abrennan89 added the qe-approved Signifies that QE has signed off on this PR label May 10, 2022
@abrennan89 abrennan89 changed the title [WIP] [SRVKS-892]: Add init container docs [SRVKS-892]: Add init container docs May 10, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2022
nalhadef
nalhadef approved these changes May 10, 2022
View reviewed changes
@nalhadef
Copy link
Contributor

I left four comments, mostly related to the use of "spec." I'm not sure if these need to be spelled out (at least the first three instances). I'm marking this as LGTM, because these are all minor.

@abrennan89 abrennan89 added the peer-review-done Signifies that the peer review team has reviewed this PR label May 10, 2022
@abrennan89 abrennan89 merged commit 6a93826 into openshift:main May 10, 2022
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.11

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.10

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 10, 2022
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #45559

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #45560

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 10, 2022
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #45561

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: #45322 failed to apply on top of branch "enterprise-4.8":

Applying: Add init container docs
Using index info to reconstruct a base tree...
M	serverless/develop/serverless-applications.adoc
Falling back to patching base and 3-way merge...
Auto-merging serverless/develop/serverless-applications.adoc
CONFLICT (content): Merge conflict in serverless/develop/serverless-applications.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add init container docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: #45322 failed to apply on top of branch "enterprise-4.7":

Applying: Add init container docs
Using index info to reconstruct a base tree...
M	serverless/develop/serverless-applications.adoc
Falling back to patching base and 3-way merge...
Auto-merging serverless/develop/serverless-applications.adoc
CONFLICT (content): Merge conflict in serverless/develop/serverless-applications.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add init container docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: #45322 failed to apply on top of branch "enterprise-4.6":

Applying: Add init container docs
Using index info to reconstruct a base tree...
M	serverless/develop/serverless-applications.adoc
Falling back to patching base and 3-way merge...
Auto-merging serverless/develop/serverless-applications.adoc
CONFLICT (content): Merge conflict in serverless/develop/serverless-applications.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add init container docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 10, 2022
Merged
Merged
Merged
@abrennan89 abrennan89 deleted the SRVKS-892 branch June 30, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgencur mgencur mgencur left review comments

@nalhadef nalhadef nalhadef approved these changes

@skonto skonto Awaiting requested review from skonto

Assignees
No one assigned
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR serverless Label for all Serverless PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.
5 participants
@abrennan89 @nalhadef @openshift-cherrypick-robot @mgencur @skonto