Skip to content

OSDOCS-1594: Combine the Authentication and authorization and Cluster… #53020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

OSDOCS-1594: Combine the Authentication and authorization and Cluster… #53020

merged 1 commit into from
Nov 21, 2022

Conversation

bmcelvee
Copy link
Contributor

@bmcelvee bmcelvee commented Nov 18, 2022 •
edited
Loading

Version(s):
4.11+

Issue:
Relates to https://issues.redhat.com/browse/OSDOCS-1594 and #51026

Link to docs preview:
http://file.rdu.redhat.com/bmcelvee/OSDOCS-1594-combine-books/authentication/assuming-an-aws-iam-role-for-a-service-account.html

QE review:
Moving existing content. No QE review required.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2022
@bmcelvee bmcelvee added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 21, 2022
@bmcelvee
Copy link
Contributor Author

@kalexand-rh here's the PR that combines the authentication books in the ROSA topic map

@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 21, 2022
@kalexand-rh
Copy link
Contributor

LGTM

GroceryBoyJr
GroceryBoyJr reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 21, 2022
@bmcelvee bmcelvee merged commit 7db219d into openshift:main Nov 21, 2022
@bmcelvee
Copy link
Contributor Author

/cherrypick enterprise-4.11

@bmcelvee
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #53056

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 21, 2022
Merged
@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #53057

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.11 branch/enterprise-4.12 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmcelvee @GroceryBoyJr @kalexand-rh @openshift-cherrypick-robot