Skip to content

Lint topic_map yml files and fail the Travis build if errors are found #53168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

aireilly
Copy link
Contributor

@aireilly aireilly commented Nov 24, 2022

Lint topic_map yml files and fail the Travis build if errors are found

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 24, 2022
@aireilly aireilly changed the title WIP - lint included YAML WIP - lint included YAML files Nov 24, 2022
@aireilly aireilly force-pushed the yaml-test branch 2 times, most recently from b9ed81c to 72b2458 Compare November 24, 2022 16:33
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 24, 2022

🤖 Updated build preview is available at:
https://53168--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35290

@aireilly aireilly force-pushed the yaml-test branch 6 times, most recently from 5e78bb9 to 387dade Compare November 24, 2022 17:16
@aireilly aireilly force-pushed the yaml-test branch 2 times, most recently from d7c42fe to 00d771c Compare November 24, 2022 20:06
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2022
@aireilly aireilly closed this Dec 13, 2022
@oraNod
Copy link

oraNod commented Dec 13, 2022

@aireilly Just curious, is there any particular reason this was closed?

@aireilly
Copy link
Contributor Author

aireilly commented Dec 13, 2022

I wanted to quickly demo this idea for colleagues, the content in the PR was just lorem ipsum stuff (apart from the yamllint script maybe). The PR served its purpose. I also need to investigate the yamllint action you mentioned above.

@aireilly
Copy link
Contributor Author

On second thoughts. No harm keeping this open to remind me to finish this :p

@aireilly aireilly reopened this Dec 13, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2023
@aireilly
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2023
@aireilly aireilly merged commit 02e0560 into openshift:main Nov 30, 2023
@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.11 enterprise-4.12 enterprise-4.13 enterprise-4.14 enterprise-4.15

@openshift-cherrypick-robot

@aireilly: cannot checkout enterprise-4.11 enterprise-4.12 enterprise-4.13 enterprise-4.14 enterprise-4.15: error checking out "enterprise-4.11 enterprise-4.12 enterprise-4.13 enterprise-4.14 enterprise-4.15": exit status 1 error: pathspec 'enterprise-4.11 enterprise-4.12 enterprise-4.13 enterprise-4.14 enterprise-4.15' did not match any file(s) known to git

In response to this:

/cherrypick enterprise-4.11 enterprise-4.12 enterprise-4.13 enterprise-4.14 enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.11

@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.12

1 similar comment
@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.12

@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.13

@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.14

@aireilly
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@aireilly: new pull request created: #68659

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aireilly: new pull request created: #68660

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aireilly: new pull request created: #68661

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aireilly: new pull request created: #68662

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aireilly: new pull request created: #68663

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aireilly: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.12 from head openshift-cherrypick-robot:cherry-pick-53168-to-enterprise-4.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-53168-to-enterprise-4.12."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly
Copy link
Contributor Author

aireilly commented Jan 8, 2024

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@aireilly: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.12 from head openshift-cherrypick-robot:cherry-pick-53168-to-enterprise-4.12: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:enterprise-4.12 and openshift-cherrypick-robot:cherry-pick-53168-to-enterprise-4.12"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly
Copy link
Contributor Author

aireilly commented Mar 5, 2024

/cherrypick service-mesh-docs-main

@openshift-cherrypick-robot

@aireilly: new pull request created: #72591

In response to this:

/cherrypick service-mesh-docs-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aireilly
Copy link
Contributor Author

aireilly commented Mar 5, 2024

/cherrypick serverless-docs-main

@aireilly
Copy link
Contributor Author

aireilly commented Mar 5, 2024

/cherrypick gitops-docs-main

@openshift-cherrypick-robot

@aireilly: new pull request could not be created: failed to create pull request against openshift/openshift-docs#serverless-docs-main from head openshift-cherrypick-robot:cherry-pick-53168-to-serverless-docs-main: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:serverless-docs-main and openshift-cherrypick-robot:cherry-pick-53168-to-serverless-docs-main"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick serverless-docs-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@aireilly: new pull request could not be created: failed to create pull request against openshift/openshift-docs#gitops-docs-main from head openshift-cherrypick-robot:cherry-pick-53168-to-gitops-docs-main: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:gitops-docs-main and openshift-cherrypick-robot:cherry-pick-53168-to-gitops-docs-main"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick gitops-docs-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants