Skip to content

Describe how to configure automatic image signature import #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Oct 4, 2017

Describe how to configure: openshift/origin#16293

@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 4, 2017

@mtrmac @runcom do you guys have some github pages or official web site we can link for documentation? Not sure if linking to a github markdown file is good idea long term ;-)

@mtrmac
Copy link
Contributor

mtrmac commented Oct 4, 2017

If you are asking about https://github.com/containers/image/blob/master/docs/registries.d.md, that’s it; I don’t think we have a more fancy website. I guess you could also link to more guide-like articles at access.redhat.com.

----

Note that all signatures imported automatically by {{product-title}} will be
"unverified" by default and will have to be verified by image administrators.
Copy link

@thomasmckay thomasmckay Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions for verification command and link to signature docs would be appreciated (just link to previous paragraph?).

@adellape
Copy link
Contributor

@mburke5678
Copy link
Contributor

@mfojtik What is the status of this PR? I have been asked to take over the associated Trello from Alex D.

@mfojtik
Copy link
Contributor Author

mfojtik commented Oct 31, 2017

@thomasmckay FYI

@mburke5678
Copy link
Contributor

@mfojtik @thomasmckay I need to get this card to QE by EOB Wednesday. Please let me know if this doc is technically complete by then so I can send it to QE.

@mburke5678
Copy link
Contributor

@mfojtik @zhouying7780 has a question on the need to restart services after editing the YAML. If you agree that this is needed, please make the changes or let me know and I can merge what you have and do a follow-up PR to add the restart. Would like to close on this.

@ncbaratta ncbaratta added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 9, 2017
@mburke5678
Copy link
Contributor

mburke5678 commented Nov 13, 2017

@mfojtik @zhouying7780 @thomasmckay Please see question above on restart. I need to close by end-of-week. If I do not hear back, I can merge this and add the restart step in a follow-up to move this issue along. We can remove later, if needed.

@mfojtik
Copy link
Contributor Author

mfojtik commented Nov 14, 2017

@mburke5678 the restart is not required, you just need to make that file accessible by master. If you run the master in container you might restart if you bind mounting the configuration file.

@mburke5678 mburke5678 removed the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 15, 2017
@mburke5678 mburke5678 merged commit 5cc7d97 into openshift:master Nov 15, 2017
@mburke5678 mburke5678 added this to the Future Release milestone Nov 15, 2017
@mburke5678
Copy link
Contributor

@mfojtik @zhouying7780 @thomasmckay
How does this look? Follow-up edit to Describe how to configure automatic image signature import

I brought down some information from the github file and moved the link to the end to de-emphasize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants