Router - changes to A/B weights discussion #5816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knobunc @mburke5678 PTAL |
|
@pecameron LGTM |
ncbaratta
added
the
peer-review-done
|
@pecameron I've been given the trello card to catch up on. This LGTM. Can I get a rebase? Then I'll merge. Sorry we missed this one. Please let me know if there's anything else for this card. |
|
LGTM |
|
@pecameron Please rebase and then this can merge. |
openshift-ci-robot
added
the
size/S
|
@bfallonf I did the rebase. PTAL. |
|
Thanks @pecameron . I'll merge. Rewording. No rev history needed. |
bfallonf
pushed a commit
to bfallonf/openshift-docs
that referenced
this pull request
Feb 5, 2018
Bug: 1477685 https://bugzilla.redhat.com/show_bug.cgi?id=1477685 Trello: BhWCH3vu https://trello.com/c/BhWCH3vu/543-3-fix-problem-in-a-b-weight-algorithm (cherry picked from commit 591a32b) xref:openshift#5816
bfallonf
pushed a commit
to bfallonf/openshift-docs
that referenced
this pull request
Feb 5, 2018
Bug: 1477685 https://bugzilla.redhat.com/show_bug.cgi?id=1477685 Trello: BhWCH3vu https://trello.com/c/BhWCH3vu/543-3-fix-problem-in-a-b-weight-algorithm (cherry picked from commit 591a32b) xref:openshift#5816
bfallonf
pushed a commit
to bfallonf/openshift-docs
that referenced
this pull request
Feb 5, 2018
Bug: 1477685 https://bugzilla.redhat.com/show_bug.cgi?id=1477685 Trello: BhWCH3vu https://trello.com/c/BhWCH3vu/543-3-fix-problem-in-a-b-weight-algorithm (cherry picked from commit 591a32b) xref:openshift#5816
bfallonf
pushed a commit
to bfallonf/openshift-docs
that referenced
this pull request
Feb 5, 2018
Bug: 1477685 https://bugzilla.redhat.com/show_bug.cgi?id=1477685 Trello: BhWCH3vu https://trello.com/c/BhWCH3vu/543-3-fix-problem-in-a-b-weight-algorithm (cherry picked from commit 591a32b) xref:openshift#5816
This was referenced Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCP 3.7
Bug: 1477685
https://bugzilla.redhat.com/show_bug.cgi?id=1477685
Trello: BhWCH3vu
https://trello.com/c/BhWCH3vu/543-3-fix-problem-in-a-b-weight-algorithm