-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add pages for new OpenShift on OpenStack provider #6020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@openshift/team-documentation @e-minguez @tomassedovic PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few comments.
|
||
In order to provision and install {product-title} on OpenStack, see | ||
link:https://access.redhat.com/documentation/en-us/reference_architectures/2017/html-single/deploying_and_managing_red_hat_openshift_container_platform_3.6_on_red_hat_openstack_platform_10[the reference architecture for Red Hat OpenStack Platform 10], | ||
which is based on link:https://docs.openstack.org/heat/latest[OpenStack Heat] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current ref. arch. is not based on Heat but in a manual procedure using the openstack cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I have to point the https://github.com/redhat-openstack/openshift-on-openstack then? But now I'm confused as I thought that complements the OSP 10 ref arch! @tomassedovic need your inputs please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
==== | ||
[IMPORTANT] | ||
The reference architecture for {product-title} on Red Hat OpenStack Platform 10 | ||
is deprecated. For OSP 13 time frame, it is being replaced with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK OCP 3.6 on OSP 10 ref. arch. is not deprecated (we've just released a few weeks ago[1]), OCP 3.4 on OSP 10 is deprecated[2]
[1] https://access.redhat.com/documentation/en-us/reference_architectures/2017/html-single/deploying_and_managing_red_hat_openshift_container_platform_3.6_on_red_hat_openstack_platform_10/
[2] https://access.redhat.com/documentation/en-us/reference_architectures/2017/html/deploying_red_hat_openshift_container_platform_3.4_on_red_hat_openstack_platform_10/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomassedovic could you please comment and help to get the better wording to point OSP >10 users to the right docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
[IMPORTANT] | ||
The reference architecture for {product-title} on Red Hat OpenStack Platform 10 | ||
is deprecated. For OSP 13 time frame, it is being replaced with the | ||
link:https://github.com/openshift/openshift-ansible-contrib/tree/master/playbooks/provisioning/openstack[Ansible driven deployment solution]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about providing links in the official documentation to the unsupported o-a-c repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look the commit message, it states that the repo is being moved and the link will have to be adjusted. So this is only a landing page, and the dependency patch. I'll put the dependency though! thanks!
5746f4a
to
725ee74
Compare
CC: @openshift/team-documentation |
The new shift-on-stack provider [0] complements and will replace some of the existing documentation and reference architectures for OCP 3.4/3.6 on OSP 10. It is planned to be the supported solution in the OSP 13 time frame. [0] https://github.com/openshift/openshift-ansible-contrib Changes: * Clarify on-premises and cloud providers cases in the Getting Started, Planning and Advanced Installation pages for the openshift-origin/enterprise distros. * Link documentation pages for the shift-on-stack provider, which is currently hosted in-repo docs. * Add links for published OCP on OSP ref. architectures * Add a deprecation note for OCP 3.4 on OSP 10 reference architecture based on Heat Templates. Note that the new provider is being moved under the openshift-ansible repo [1]. The links must be updated after the documentation moved as the part of that change request. "Configuring OpenShift Origin for OpenStack with Ansible" will likely need some updates as well. [1] openshift/openshift-ansible#5797 . Signed-off-by: Bogdan Dobrelya <[email protected]>
725ee74
to
33e8b58
Compare
Looking at https://docs.openshift.com/ I'm wondering if the descriptions given for "OpenShift Container Platform - Red Hat's private, on-premise" and "OpenShift Dedicated - Red Hat's managed public cloud" fits the proposed changes. It seems that we need to provide a comparison to over products to clarify the cloud providers case for Origin/Enterprise?.. Any help with that? |
The reference architecture for automated installations based on | ||
link:https://docs.openstack.org/heat/latest[OpenStack Heat] templates for | ||
link:https://access.redhat.com/documentation/en-us/reference_architectures/2017/html/deploying_red_hat_openshift_container_platform_3.4_on_red_hat_openstack_platform_10[{product-title} (OCP 3.4) on Red Hat OpenStack Platform 10] | ||
is deprecated. For OSP 13 time frame, it is being replaced with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's been officially deprecated. More like it's not being actively developed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the docs should state something is not being actively developed anymore :) sounds a little bit too much of dramatic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let it be 'unsupported'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Some of the basic configuration may be assisted by that reference architecture | ||
and the | ||
xref:../../install_config/install/prerequisites#prereq-cloud-provider-considerations[cloud provider considerations]. | ||
For advanced configuration prerequisites, like DNS, load balancing and high |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference architecture handles complex deployments including HA, DNS and LB as well I believe.
I would just say that it describes a manual way of configuring the OpenStack resources and installing OpenShift and the playbooks below automate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-minguez would you comment please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomassedovic is right, the current ref. arch. includes how to deploy DNS, LB and an HA OCP environment based on manual steps for the infrastructure, then openshift-ansible for installing OCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks
Describe alternative cloud solitions in the planning OpenShift Enterprise installation pages. For some cases, OpenShift Dedicated or Online might be a better fit. This makes things more clear for users from the first docs pages read. Additionally, highlight the Dedicated alternative, when describing the cloud hosted infrustracture configuration prerequisites in the Enterprise advanced installation guide. Signed-off-by: Bogdan Dobrelya <[email protected]>
Addressed the #6020 (comment) in the follow-up commit |
* _Will you manage your dedicated cloud hosted infrastructure or prefer | ||
having it managed as a service?_ See the | ||
link:https://www.openshift.com/dedicated/index.html[OpenShift Dedicated] | ||
product offering that might fit the case better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos Chris Pitman for explaining this on a mail list
Signed-off-by: Bogdan Dobrelya <[email protected]>
^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's time to rebase on openshift/openshift-ansible#6039 merged |
Point to the official location of the provider's new home. Signed-off-by: Bogdan Dobrelya <[email protected]>
The dependency patch is now merged, and the external links in this patch adjusted. So this one is good to go now. PTAL folks! |
sup ^^ |
/lgtm |
Folks can we have this merged please? |
Yeah, not sure why the bot didn't merge it automatically. |
@sdodson @bogdando cc. @adellape |
@mburke5678 Sorry, I shouldn't have merged this. I lost track of which repo I was in. I suspect the right thing to do is revert it and allow docs team to properly review the content. As far as technical accuracy it looks accurate to me but @tomassedovic would be the SME. |
@mburke5678 @adellape that's a good point. I wish more folks from the documentation team have reviewed this patch, indeed. It's been open for a month, I've got a single peer review and hoped that it came from the docs team (I can't see the @openshift/team-documentation members). So that brought I little bit of confusion for us all. Would be nice to improve review process for future cooperation. |
Follow up proofread edits #6610 |
@bogdando @sdodson Should the links at the following locations be in Origin in addition to OCP? The ifdef is for OCP only. |
@mburke5678 I didn't propose those commercial alternatives for non-commercial Origin (IIUC) by intention. I think those should only be visible for OCP (Enterprise) pages, otherwise it may be treated like ads IMO. Feel free to alter this as you think it should be though. Either way would work for me. |
@bogdando @sdodson Please see @aheslin comment in my follow-up: |
@sdodson @bogdando @tomassedovic Should these changes have been added to Enterprise? |
@mburke5678 I finished placing the remaining ifdefs related to this PR as part of #8535 and #8537. So this content should all be appropriately ifdef'd for Origin only now on the master, enterprise-3.9, and enterprise-3.10 branches; if/when it's vetted for downstream docs, we can remove or adjust those as needed. |
The new shift-on-stack provider [0] complements and will replace some of
the existing documentation for OCP on OSP 10 reference architecture.
It is planned to be the supported solution in the OSP 13 time frame.
Note that the provider is being moved under the openshift-ansible
repo [1]. Its link must be updated after the documentation moved as
the part of that change request.
"Configuring OpenShift Origin for OpenStack with Ansible" will likely
need some updates as well.
[0] https://github.com/openshift/openshift-ansible-contrib
[1] openshift/openshift-ansible#6039
Changes:
the Getting Started, Planning and Advanced Installation pages for
the openshift-origin/enterprise distros.
is currently hosted in-repo docs.
architecture based on Heat Templates.
Highlight other cloud offerings as well.
Describe alternative cloud solitions in the planning OpenShift
Enterprise installation pages. For some cases, OpenShift Dedicated
or Online might be a better fit. This makes things more clear for
users from the first docs pages read.
Additionally, highlight the Dedicated alternative, when describing
the cloud hosted infrustracture configuration prerequisites in the
Enterprise advanced installation guide.
Depends-on openshift/openshift-ansible#6039
Signed-off-by: Bogdan Dobrelya [email protected]