Skip to content

Update installation-azure-preparing-diskencryptionsets.adoc #61645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

shane-snyder
Copy link
Contributor

@shane-snyder shane-snyder commented Jun 23, 2023

Removed --enable-soft-delete true from az keyvault create command

Version(s):
All versions

Issue:
Starting with the az cli release 2.41.0 released on October 11, 2022, the --enable-soft-delete flag has been removed. Trying to run this will give you "unrecognized arguments". This is also enabled by default according to Microsoft's documentation

az keyvault create -n $KEYVAULT_NAME -g $RESOURCEGROUP -l $LOCATION --enable-purge-protection true --enable-soft-delete true
unrecognized arguments: --enable-soft-delete true

Link to docs preview:
https://61645--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_azure/enabling-user-managed-encryption-azure.html#preparing-disk-encryption-sets

QE review:

  • QE has approved this change.

Additional information:

Removed --enable-soft-delete true from az keyvault create command
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2023
@ocpdocs-previewbot
Copy link

@kalexand-rh
Copy link
Contributor

@jinyunma, will you please confirm this change and that it should be applied to all maintained docs versions?

@jinyunma
Copy link

@jinyunma, will you please confirm this change and that it should be applied to all maintained docs versions?

the update looks good to me. It can be applied to all maintained docs versions.
FYI, in our CI jobs, we always use command az keyvault create with option -enable-purge-protection true and without option --enable-soft-delete true, it works well.

@bscott-rh
Copy link
Contributor

Disk encryption was added to the OCP docs in 4.11, so I will merge this change to 4.11+.

@bscott-rh bscott-rh merged commit e732de0 into openshift:main Jul 31, 2023
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #62971

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #62972

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #62973

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@bscott-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.14 from head openshift-cherrypick-robot:cherry-pick-61645-to-enterprise-4.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #62976

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants