Skip to content

Added document for labeling AWS resources on existing clusters #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2017
Merged

Added document for labeling AWS resources on existing clusters #6237

merged 1 commit into from
Nov 28, 2017

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented Nov 8, 2017 •
edited
Loading

@ahardin-rh ahardin-rh added this to the Future Release milestone Nov 8, 2017
@ahardin-rh ahardin-rh self-assigned this Nov 8, 2017
@ahardin-rh ahardin-rh mentioned this pull request Nov 8, 2017
Closed
@ahardin-rh
Copy link
Contributor Author

@kwoodson @sdodson @rrati PTAL

I have this appearing in Origin in OCP docs. Please let me know if this should apply to Dedicated docs as well. Thanks!

@ahardin-rh
Copy link
Contributor Author

@kwoodson @sdodson @rrati PTAL and let me know if this should also be applied to the Dedicated doc set. Thanks!

sdodson
sdodson reviewed Nov 14, 2017
View reviewed changes
admin_guide/aws_cluster_labeling.adoc Outdated
+
[source,bash]
----
# ssystemctl restart atomic-openshift-master-api atomic-openshift-master-controller atomic-openshift-node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, systemctl

@sdodson
Copy link
Member

sdodson commented Nov 14, 2017

@kwoodson @sdodson @rrati PTAL and let me know if this should also be applied to the Dedicated doc set. Thanks!

It shouldn't be necessary for dedicated.

@kwoodson
Copy link

@sdodson, @ahardin-rh, I'd imagine we'd want the labeling documentation. I think we should alert operators of this requirement for dedicated. Just my .02.

@sdodson
Copy link
Member

sdodson commented Nov 14, 2017

@sdodson, @ahardin-rh, I'd imagine we'd want the labeling documentation. I think we should alert operators of this requirement for dedicated. Just my .02.

I'd assumed we (Red Hat) were the operators of those environments and dedicated admins needed to take no action of their own?

@kwoodson
Copy link

@sdodson, Maybe I am misunderstanding the dedicated docs. Is the operations team the only consumers of those? Do we have external consumers running dedicated? If not, then that's fine.

I know that we've been deploying dedicated clusters since before these tags were mandated. I'm fine if we do not want to doc it for dedicated. I know there is work to do and we need to go and apply these tags to clusters.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2017
@ahardin-rh ahardin-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 28, 2017
adellape
adellape approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 28, 2017
@ahardin-rh
Copy link
Contributor Author

[rev_history]
|xref:../admin_guide/aws_cluster_labeling.adoc#admin-guide-aws-cluster-labeling[Labeling Clusters for Amazon Web Services (AWS)]
|New topic describing how to label an existing {product-title} cluster running on Amazon Web Services (AWS).
%

@ahardin-rh ahardin-rh merged commit 2e8a237 into openshift:master Nov 28, 2017
@ahardin-rh ahardin-rh mentioned this pull request Nov 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdodson sdodson sdodson left review comments

@adellape adellape adellape approved these changes

Assignees

@ahardin-rh ahardin-rh

Labels
branch/enterprise-3.7 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 3.7 GA
Development

Successfully merging this pull request may close these issues.
6 participants
@ahardin-rh @sdodson @kwoodson @adellape @vikram-redhat @openshift-ci-robot