Skip to content

TELCODOCS-1178: Remove content from a CR on managed clusters #62775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2023
Merged

TELCODOCS-1178: Remove content from a CR on managed clusters #62775

merged 1 commit into from
Sep 12, 2023

Conversation

amolnar-rh
Copy link
Contributor

@amolnar-rh amolnar-rh commented Jul 25, 2023 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 25, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1178 which is a valid jira issue.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/TELCODOCS-1178

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 25, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://62775--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/24397

aireilly
aireilly reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a few quick comments. This procedure would really benefit from an example.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 15, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1178 which is a valid jira issue.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/TELCODOCS-1178

Link to docs preview:
https://62775--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-configuring-managed-clusters-policies#ztp-removing-content-from-managed-clusters_ztp-configuring-managed-clusters-policies

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 15, 2023
imiller0
imiller0 reviewed Aug 21, 2023
View reviewed changes
Copy link

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure and example are good, but the affected policy needs to be the group policy. Thanks!

aireilly
aireilly reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@aireilly aireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few nits

@josclark42
Copy link

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 31, 2023 •
edited by openshift-ci bot
Loading

@amolnar-rh: This pull request references TELCODOCS-1178 which is a valid jira issue.

In response to this:

Version(s): 4.14+

Issue: https://issues.redhat.com/browse/TELCODOCS-1178

Link to docs preview:
https://62775--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-configuring-managed-clusters-policies#ztp-removing-content-from-managed-clusters_ztp-configuring-managed-clusters-policies

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amolnar-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 31, 2023
@dfitzmau
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 31, 2023
dfitzmau
dfitzmau reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 11 commits that need to be squashed.

@mburke5678 , would you be OK to perform an editorial on my review comments?

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 31, 2023
@dfitzmau
Copy link
Contributor

dfitzmau commented Sep 1, 2023

Hi @amolnar-rh .

Changes LGTM. I added some additional comments inline that you might consider if you need to make more updates.

@josclark42
Copy link

LGTM

@amolnar-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 12, 2023
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 12, 2023
sheriff-rh
sheriff-rh approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @amolnar-rh ! Merging to 4.14+.

@sheriff-rh sheriff-rh merged commit e6bd5cb into openshift:main Sep 12, 2023
@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #64632

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.13

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.12

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #64840

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #64841

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 18, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #64842

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djuran djuran djuran left review comments

@mburke5678 mburke5678 mburke5678 left review comments

@imiller0 imiller0 imiller0 left review comments

@dfitzmau dfitzmau dfitzmau left review comments

@aireilly aireilly aireilly left review comments

@sheriff-rh sheriff-rh sheriff-rh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.14 GA
Development

Successfully merging this pull request may close these issues.