Skip to content

[OSDOCS-7196]: Removing step about manual rollout #64595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lahinson
Copy link
Contributor

@lahinson lahinson commented Sep 11, 2023

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OSDOCS-7196

Link to docs preview: https://64595--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/recommended-performance-scale-practices/recommended-etcd-practices#etcd-changing-hardware-speed-tolerance_recommended-etcd-practices

QE review:

  • QE has approved this change.

Additional information: This PR removes the step about forcing an etcd rollout, as the rollout should happen automatically.
Related PR: #63875

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2023
@ocpdocs-previewbot
Copy link

@lahinson
Copy link
Contributor Author

/cc dusk125

@openshift-ci openshift-ci bot requested a review from dusk125 September 11, 2023 16:23
@dusk125
Copy link

dusk125 commented Sep 11, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@lahinson
Copy link
Contributor Author

/cc geliu2016

@openshift-ci openshift-ci bot requested a review from geliu2016 September 11, 2023 16:26
@dusk125
Copy link

dusk125 commented Sep 11, 2023

For context: the env var controller in the Cluster Etcd Operator will notice the change to the profile and automatically start the etcd rollout making the manual step unnecessary.

@lahinson
Copy link
Contributor Author

@geliu2016 When you can, PTAL at this doc PR. Thank you!

@geliu2016
Copy link

/lgtm

Copy link

@geliu2016 geliu2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lahinson
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 12, 2023
@jab-rh jab-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 12, 2023
@jab-rh
Copy link
Contributor

jab-rh commented Sep 12, 2023

@lahinson, LGTM, thanks!

@lahinson
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 12, 2023
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 12, 2023
@skrthomas skrthomas merged commit 91d5e95 into openshift:main Sep 12, 2023
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@skrthomas: new pull request created: #64629

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants