OADP 2419 Release Notes and Update Notes fixed #67404

CarmiWisemon · 2023-11-06T08:51:48Z

OADP 1.3.0

OCP 4.13+

Resolves - https://issues.redhat.com/browse/OADP-2419

Deploy preview - https://67404--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-release-notes

(1.3 Release & upgrade notes)

https://67404--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-release-notes#Upgrade-notes-1.2.0_oadp-release-notes

(1.2 Upgrade notes)

ocpdocs-previewbot · 2023-11-06T16:00:29Z

🤖 Updated build preview is available at:
https://67404--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35078

modules/oadp-release-notes-1-2-0.adoc

modules/oadp-release-notes-1-3-0.adoc

stillalearner

lgtm

modules/oadp-release-notes-1-3-0.adoc

CarmiWisemon · 2023-11-22T09:06:36Z

/label OADP
/label peer-review-needed

CarmiWisemon · 2023-11-28T12:43:05Z

/label merge-review-needed

CarmiWisemon · 2023-11-28T12:44:57Z

@ousleyp
Thank you for your comments.
I made the changes you requested.
The GA for the release is today.
Please merge the PR today.
Thank you for all of your help!
Carmi

ousleyp

Hi Carmi, I had not done a full merge review when I made my previous comment. There are still items to resolve before we can merge. Please take a look at my comments/suggestions and let me know if you have any questions. Thank you!

cc @anarnold97 (for awareness - I know the release was imminent)

modules/oadp-backing-up-dpa-configuration-1-2-0.adoc

modules/oadp-backing-up-dpa-configuration-1-3-0.adoc

modules/oadp-converting-dpa-to-new-version-1-3-0.adoc

modules/oadp-upgrading-oadp-operator-1-3-0.adoc

modules/oadp-verifying-upgrade-1-2-0.adoc

modules/oadp-verifying-upgrade-1-3-0.adoc

CarmiWisemon · 2023-11-29T12:16:23Z

/label merge-review-needed

CarmiWisemon · 2023-11-29T12:18:34Z

@ousleyp
Thank you for your comments and your helpful review.
I have implemented the changes you requested.
Please merge the PR as soon as possible.
Thank you for your help!!!
Carmi

kalexand-rh · 2023-11-29T15:23:30Z

modules/oadp-upgrading-oadp-operator-1-2-0.adoc

+. Change your subscription channel for the OADP Operator from `stable-1.1` to `stable-1.2`.
+. Allow time for the Operator and containers to update and restart.
+
+For general Operator upgrade instructions, see xref:../../operators/admin/olm-upgrading-operators.adoc#olm-changing-update-channel_olm-upgrading-operators[Updating installed Operators].


You can't have an xref in a module. This needs to be in an .Additional resources section in the assembly.

I moved it to the assembly.

kalexand-rh · 2023-11-29T15:24:14Z

modules/oadp-upgrading-oadp-operator-1-3-0.adoc

+. Change your subscription channel for the OADP Operator from `stable-1.2` to `stable-1.3`.
+. Allow time for the Operator and containers to update and restart.
+
+For general Operator upgrade instructions, see xref:../../operators/admin/olm-upgrading-operators.adoc#olm-changing-update-channel_olm-upgrading-operators[Updating installed Operators].


Same as in the other module.

kalexand-rh · 2023-11-29T15:27:39Z

modules/oadp-backing-up-dpa-configuration-1-2-0.adoc

+You must back up your current `DataProtectionApplication` (DPA) configuration.
+
+.Procedure
+. Save your current DPA configuration by running the following command:


Suggested change

. Save your current DPA configuration by running the following command:

* Save your current DPA configuration by running the following command:

kalexand-rh · 2023-11-29T15:28:10Z

modules/oadp-backing-up-dpa-configuration-1-2-0.adoc

+----
+$ oc get dpa -n openshift-adp -o yaml > dpa.orig.backup
+----
+. Verify that you saved the values.


Unless you're going to explain how, remove this line and reformat the previous step to comply with the single-step procedure guidelines:

* Save your current DPA configuration by running the following command:

kalexand-rh · 2023-11-29T15:29:04Z

modules/oadp-converting-dpa-to-new-version-1-3-0.adoc

+
+:_mod-docs-content-type: PROCEDURE
+
+[id="converting-dpa-to-the-new-version-1-3-0_{context}"]


Suggested change

[id="converting-dpa-to-the-new-version-1-3-0_{context}"]

[id="oapd-converting-dpa-to-new-version-1-3-0_{context}"]

The filename and anchor need to match.

kalexand-rh · 2023-11-29T15:33:42Z

modules/oadp-converting-dpa-to-new-version-1-3-0.adoc

+
+.Procedure
+. Click *Operators* → *Installed Operators* and select the OADP Operator.
+. Under *Provided APIs*, click *Create instance* in the *DataProtectionApplication* box.


I don't have the UI, but positional language like "under" is either disallowed or to be avoided. I suspect that the "Highlighting by element" section of the ISG can help remediate this.

kalexand-rh · 2023-11-29T15:37:17Z

modules/oadp-release-notes-1-3-0.adoc

+
+[NOTE]
+====
+In a future version of OADP, the `restic` uploader type will be deprecated and `kopia` will become the default `uploaderType` value.


Thank you for not calling out expected versions when this will be deprecated.

kalexand-rh · 2023-11-29T16:38:08Z

Your build is failing because of a new check we just enabled. These bugs are all set to the Red Hat Employee security level, so customers can't see them. You can edit the RN text to still talk about the fixes/improvements, if that makes sense, or if the bugs can have an external security setting, you can talk with engineering about removing the security restriction, but you can't include the links as they are.

CarmiWisemon force-pushed the oadp2419rnfixed branch from b6fe672 to e777d48 Compare November 6, 2023 13:43

CarmiWisemon changed the title ~~WIP - OADP 2419 Release Notes fixed~~ WIP - OADP 2419 Release Notes and Update Notes fixed Nov 6, 2023

kalexand-rh closed this Nov 6, 2023

kalexand-rh reopened this Nov 6, 2023

CarmiWisemon force-pushed the oadp2419rnfixed branch 6 times, most recently from b70b69f to c970d55 Compare November 14, 2023 16:05

weshayutin suggested changes Nov 14, 2023

View reviewed changes

CarmiWisemon force-pushed the oadp2419rnfixed branch 4 times, most recently from f22f411 to f2ab0ef Compare November 19, 2023 08:46

stillalearner approved these changes Nov 20, 2023

View reviewed changes

CarmiWisemon force-pushed the oadp2419rnfixed branch 2 times, most recently from 99956bf to bc1eec2 Compare November 21, 2023 13:31

CarmiWisemon changed the title ~~WIP - OADP 2419 Release Notes and Update Notes fixed~~ OADP 2419 Release Notes and Update Notes fixed Nov 21, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023

kaovilai reviewed Nov 21, 2023

View reviewed changes

modules/oadp-release-notes-1-3-0.adoc Outdated Show resolved Hide resolved

CarmiWisemon force-pushed the oadp2419rnfixed branch 2 times, most recently from 842c45c to a8e9a91 Compare November 22, 2023 08:57

openshift-ci bot added the OADP Label for all OADP PRs label Nov 22, 2023

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 28, 2023

ousleyp added merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 28, 2023

ousleyp reviewed Nov 29, 2023

View reviewed changes

ousleyp removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 29, 2023

CarmiWisemon force-pushed the oadp2419rnfixed branch 3 times, most recently from 583539c to 30d8a05 Compare November 29, 2023 12:12

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 29, 2023

kalexand-rh reviewed Nov 29, 2023

View reviewed changes

OADP 2419 Release Notes F

2645f3d

CarmiWisemon force-pushed the oadp2419rnfixed branch from 30d8a05 to 2645f3d Compare November 29, 2023 15:38

K edits

de18a3a

anarnold97 mentioned this pull request Nov 29, 2023

OADP 2419 Release Notes and Update Notes for OADP 1.3.0 && OADP 1.2 #68590

Merged

kalexand-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 29, 2023

CarmiWisemon closed this Nov 30, 2023

anarnold97 mentioned this pull request Sep 17, 2024

OADP-4872: Remove OADP 1.3 release notes from OCP 4.16 #81876

Merged

1 task

	. Save your current DPA configuration by running the following command:
	* Save your current DPA configuration by running the following command:


		:_mod-docs-content-type: PROCEDURE

		[id="converting-dpa-to-the-new-version-1-3-0_{context}"]

	[id="converting-dpa-to-the-new-version-1-3-0_{context}"]
	[id="oapd-converting-dpa-to-new-version-1-3-0_{context}"]

OADP 2419 Release Notes and Update Notes fixed #67404

OADP 2419 Release Notes and Update Notes fixed #67404

Uh oh!

Conversation

CarmiWisemon commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stillalearner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CarmiWisemon commented Nov 22, 2023

Uh oh!

CarmiWisemon commented Nov 28, 2023

Uh oh!

CarmiWisemon commented Nov 28, 2023

Uh oh!

ousleyp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CarmiWisemon commented Nov 29, 2023

Uh oh!

CarmiWisemon commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kalexand-rh commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

CarmiWisemon commented Nov 6, 2023 •

edited

Loading

ocpdocs-previewbot commented Nov 6, 2023 •

edited

Loading

CarmiWisemon commented Nov 29, 2023 •

edited

Loading

kalexand-rh commented Nov 29, 2023 •

edited

Loading