Skip to content

TELCODOCS-1453: Adding SNO post-install config for OLM #68117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

TELCODOCS-1453: Adding SNO post-install config for OLM #68117

merged 1 commit into from
Nov 28, 2023

Conversation

rohennes
Copy link
Contributor

@rohennes rohennes commented Nov 17, 2023 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-1453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

TELCODOCS-1453: SNO post-install recommended config for to remove OLM monitoring component.

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1453

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-1453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

TELCODOCS-1453: SNO post-install recommended config for to remove OLM monitoring component.

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1453

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 17, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 17, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://68117--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/34745

@rohennes rohennes force-pushed the TELCODOCS-1453-OLM branch 2 times, most recently from ca83acb to 84980dd Compare November 17, 2023 14:34
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-1453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

TELCODOCS-1453: SNO post-install recommended config for to remove OLM monitoring component.

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1453

Link to docs preview:
https://68117--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu#ztp-sno-du-reducing-resource-usage-with-olm-pprof_sno-configure-for-vdu

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2023 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-1453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

TELCODOCS-1453: SNO post-install recommended config to remove OLM monitoring component.

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1453

Link to docs preview:
https://68117--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu#ztp-sno-du-reducing-resource-usage-with-olm-pprof_sno-configure-for-vdu

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Missxiaoguo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@mpmaruthu
Copy link

Telco CNF QE: Looks good to me.
/Peri M

@rohennes
Copy link
Contributor Author

/label peer-review-needed
/label telco

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR telco Label for all Telco PRs labels Nov 23, 2023
@agantony
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 23, 2023
agantony
agantony reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Added a few suggestions for your consideration; overall lgtm!

modules/ztp-sno-du-reducing-resource-usage-with-olm-pprof.adoc Outdated
[id="ztp-sno-du-reducing-resource-usage-with-olm-pprof_{context}"]
= Operator Lifecycle Manager

{sno-caps} clusters that run DU workloads require consistent access to CPU resources. Operator Lifecycle Manager (OLM) periodically gathers performance data from Operators, which causes a spike in CPU usage. The following `ConfigMap` custom resource (CR) disables the gathering of Operator performance data by OLM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{sno-caps} clusters that run DU workloads require consistent access to CPU resources. Operator Lifecycle Manager (OLM) periodically gathers performance data from Operators, which causes a spike in CPU usage. The following `ConfigMap` custom resource (CR) disables the gathering of Operator performance data by OLM.
{sno-caps} clusters that run DU workloads require consistent access to CPU resources. The Operator Lifecycle Manager (OLM) collects performance data from operators at regular intervals, resulting in an increase in CPU utilisation. The following `ConfigMap` custom resource (CR) disables the collection of Operator performance data by the OLM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DU ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great rewrite, thanks! FYI - OLM should have "the" before it according to OCP glossary.

modules/ztp-sno-du-reducing-resource-usage-with-olm-pprof.adoc

{sno-caps} clusters that run DU workloads require consistent access to CPU resources. Operator Lifecycle Manager (OLM) periodically gathers performance data from Operators, which causes a spike in CPU usage. The following `ConfigMap` custom resource (CR) disables the gathering of Operator performance data by OLM.

.Recommended cluster OLM configuration (`ReduceOLMFootprint.yaml`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ReduceOLMFootprint.yaml) is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - it links to a file in a recommend cluster spec container

snippets/ztp_ReduceOLMFootprint.yaml
data:
pprof-config.yaml: |
disabled: True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space??

Copy link
Contributor Author

@rohennes rohennes Nov 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's generally best practice to leave a space at the end of a file. Snippets perhaps are a bit different but doesn't really make much difference in the output 🤷‍♂️

@agantony
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 28, 2023

New changes are detected. LGTM label has been removed.

@rohennes
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot
Loading

@rohennes: This pull request references TELCODOCS-1453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

TELCODOCS-1453: SNO post-install recommended config to remove OLM monitoring component.

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/TELCODOCS-1453

Link to docs preview:
https://68117--docspreview.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu#ztp-sno-du-reducing-resource-usage-with-olm-pprof_sno-configure-for-vdu

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 28, 2023
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 28, 2023
@mburke5678 mburke5678 merged commit 06f2d9c into openshift:main Nov 28, 2023
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.11

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@mburke5678: #68117 failed to apply on top of branch "enterprise-4.11":

Applying: TELCODOCS-1453: Adding SNO post-install config for OLM
.git/rebase-apply/patch:57: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu.adoc
Falling back to patching base and 3-way merge...
Auto-merging scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu.adoc
CONFLICT (content): Merge conflict in scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 TELCODOCS-1453: Adding SNO post-install config for OLM
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: #68117 failed to apply on top of branch "enterprise-4.12":

Applying: TELCODOCS-1453: Adding SNO post-install config for OLM
.git/rebase-apply/patch:57: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu.adoc
Falling back to patching base and 3-way merge...
Auto-merging scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu.adoc
CONFLICT (content): Merge conflict in scalability_and_performance/ztp_far_edge/ztp-reference-cluster-configuration-for-vdu.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 TELCODOCS-1453: Adding SNO post-install config for OLM
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #68455

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #68456

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #68457

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2023
Merged
This was referenced Nov 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agantony agantony agantony left review comments

Assignees

@Missxiaoguo Missxiaoguo

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. telco Label for all Telco PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rohennes @openshift-ci-robot @ocpdocs-previewbot @Missxiaoguo @mpmaruthu @agantony @mburke5678 @openshift-cherrypick-robot